Merge pull request #701 from fartem/ci-31

2024-08-07 v. 6.4.1.1: refactored CI jobs

Author: fartem

ci/ci_job.rb

@@ -6,19 +6,24 @@ module CI
   # Use it to create concrete CI jobs.
   class CIJob
     PROCESS_NO_IMPL_ERROR = "No implementation for process in #{self.class.name}"
+
     private_constant :PROCESS_NO_IMPL_ERROR
 
     # Main entry of job class that runs your check.
     def run
       puts("#{self.class.name} started...")
+
       process
+
       puts("#{self.class.name} ended without errors!")
     end
 
     # Use this method in your realization when task completed with error.
     def end_with_error(details)
       details.call
+
       puts("#{self.class.name} ended with an error.")
+
       exit(1)
     end
 

ci/links_checker.rb

@@ -20,10 +20,11 @@ def check(difficulty)
         lines = ::IO.readlines("#{path}/#{file_name}")
         has_comment = false
         lines.each do |line|
-          if line.start_with?('# https://leetcode.com/')
-            has_comment = true
-            break
-          end
+          next unless line.start_with?('# https://leetcode.com/')
+
+          has_comment = true
+
+          break
         end
 
         end_with_error(-> { puts("LinksChecker ends with an error from #{file_name}.") }) unless has_comment

ci/readme_checker.rb

@@ -19,10 +19,7 @@ def check(difficulty)
       readme = ::File.readlines('./README.md')
 
       solutions.each do |file_name|
-        links_count = 0
-        readme.each do |line|
-          links_count += 1 if line.include?(file_name)
-        end
+        links_count = readme.count { |line| line.include?(file_name) }
 
         end_with_error(-> { puts("ReadmeChecker ends with an error from #{file_name}.") }) if links_count != 1
       end