fix integer overflow in hawkeye/src/sbox_database.cpp (#611)

Sascha-Tommasone · web-flow · commit 39d1eaa532d4 · 2025-04-08T21:31:34.000+02:00
diff --git a/plugins/hawkeye/src/sbox_database.cpp b/plugins/hawkeye/src/sbox_database.cpp
@@ -304,7 +304,7 @@ namespace hal
                 return ERR("S-box '" + name + "' has bit-size greater 8, but only S-boxes of up to 8 bits are supported");
             }
 
-            for (u8 alpha = 0; alpha < sbox.size(); alpha++)
+            for (size_t alpha = 0; alpha < sbox.size(); alpha++)
             {
                 std::vector<u8> sbox_alpha;
                 for (u32 i = 0; i < sbox.size(); i++)

Original file line number	Diff line number	Diff line change
`@@ -304,7 +304,7 @@ namespace hal`
`304`	`304`	`return ERR("S-box '" + name + "' has bit-size greater 8, but only S-boxes of up to 8 bits are supported");`
`305`	`305`	`}`
`306`	`306`
`307`		`- for (u8 alpha = 0; alpha < sbox.size(); alpha++)`
	`307`	`+ for (size_t alpha = 0; alpha < sbox.size(); alpha++)`
`308`	`308`	`{`
`309`	`309`	`std::vector<u8> sbox_alpha;`
`310`	`310`	`for (u32 i = 0; i < sbox.size(); i++)`