CL-143 Fix file lock release

* Files access fixed: class FileSide is now IDisposable
* disposing FileSide instance frees the local file lock

Author: Piotr Rutkowski

CHANGELOG.md

@@ -1,6 +1,11 @@
 Changelog
 =========
 
+v1.1.6
+------
+
+- Files access fixed: class `FileSide` is now `IDisposable` - disposing `FileSide` instance frees the local file lock
+
 v1.1.5
 ------
 

src/Draftable.CompareAPI.Client/Comparisons.cs

@@ -536,14 +536,25 @@ public async Task DeleteAsync([NotNull] string identifier, CancellationToken can
         ///     other overloads to create <see cref="Side" /> objects.
         /// </remarks>
         [PublicAPI]
-        public abstract class Side
+        public abstract class Side : IDisposable
         {
             internal Side() { }
 
             [NotNull] protected abstract IEnumerable<KeyValuePair<string, string>> FormData { get; }
 
             [NotNull] protected abstract IEnumerable<KeyValuePair<string, Stream>> FileContent { get; }
 
+            protected virtual void Dispose(bool disposing)
+            {
+                // does nothing.
+            }
+
+            public void Dispose()
+            {
+                Dispose(true);
+                GC.SuppressFinalize(this);
+            }
+
             /// <exception cref="ArgumentOutOfRangeException"><paramref name="sideName" /> must be one of "left" or "right".</exception>
             [Pure]
             [NotNull]
@@ -725,6 +736,12 @@ internal FileSide([NotNull] Stream file, [NotNull] string fileType, [CanBeNull]
 
             protected override IEnumerable<KeyValuePair<string, Stream>> FileContent =>
                 new[] {new KeyValuePair<string, Stream>("file", _file)};
+
+            protected override void Dispose(bool disposing)
+            {
+                base.Dispose(disposing);
+                _file.Dispose();
+            }
         }
 
 

src/Sample.Core/ComparisonsSample.cs

@@ -140,8 +140,10 @@ private static Comparison CreateComparisonFromData(Comparisons client)
         {
             var identifier = Comparisons.GenerateIdentifier();
 
-            return client.Create(Comparisons.Side.FromFile(SampleFileLeft),
-                                 Comparisons.Side.FromFile(SampleFileRight),
+            using(var leftSide = Comparisons.Side.FromFile(SampleFileLeft))
+                using(var rightSide = Comparisons.Side.FromFile(SampleFileRight))
+                    return client.Create(leftSide,
+                                 rightSide,
                                  identifier,
                                  expires: TimeSpan.FromMinutes(30));
         }