From 2bb08de1027e25f7a7935f6876a2720291d6a04d Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sun, 20 Nov 2022 07:13:42 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- prep_data.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/prep_data.py b/prep_data.py index 7676794..3c0a36d 100644 --- a/prep_data.py +++ b/prep_data.py @@ -12,7 +12,26 @@ # Extract data file with tarfile.open("summary.tar.gz", "r:gz") as tar: - tar.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar) with gzip.open("sumdata/train/train.article.txt.gz", "rb") as gz: with open("sumdata/train/train.article.txt", "wb") as out: