DocumentPersister::$collection is always set, make it non-nullable

Author: GromNaN

lib/Doctrine/ODM/MongoDB/Persisters/DocumentPersister.php

@@ -89,7 +89,7 @@
  */
 final class DocumentPersister
 {
-    private ?Collection $collection = null;
+    private Collection $collection;
 
     private ?Bucket $bucket = null;
 
@@ -226,7 +226,6 @@ public function executeInserts(array $options = []): void
         }
 
         try {
-            assert($this->collection instanceof Collection);
             $this->collection->insertMany($inserts, $options);
         } catch (DriverException $e) {
             $this->queuedInserts = [];
@@ -334,7 +333,6 @@ private function executeUpsert(object $document, array $options): void
         }
 
         try {
-            assert($this->collection instanceof Collection);
             $this->collection->updateOne($criteria, $data, $options);
 
             return;
@@ -344,7 +342,6 @@ private function executeUpsert(object $document, array $options): void
             }
         }
 
-        assert($this->collection instanceof Collection);
         $this->collection->updateOne($criteria, ['$set' => new stdClass()], $options);
     }
 
@@ -398,7 +395,6 @@ public function update(object $document, array $options = []): void
 
             $options = $this->getWriteOptions($options);
 
-            assert($this->collection instanceof Collection);
             $result = $this->collection->updateOne($query, $update, $options);
 
             if (($this->class->isVersioned || $this->class->isLockable) && $result->getModifiedCount() !== 1) {
@@ -439,7 +435,6 @@ public function delete(object $document, array $options = []): void
 
         $options = $this->getWriteOptions($options);
 
-        assert($this->collection instanceof Collection);
         $result = $this->collection->deleteOne($query, $options);
 
         if (($this->class->isVersioned || $this->class->isLockable) && ! $result->getDeletedCount()) {
@@ -452,7 +447,6 @@ public function delete(object $document, array $options = []): void
      */
     public function refresh(object $document): void
     {
-        assert($this->collection instanceof Collection);
         $query = $this->getQueryForDocument($document);
         $data  = $this->collection->findOne($query);
         if ($data === null) {
@@ -498,7 +492,6 @@ public function load($criteria, ?object $document = null, array $hints = [], int
             $options['sort'] = $this->prepareSort($sort);
         }
 
-        assert($this->collection instanceof Collection);
         $result = $this->collection->findOne($criteria, $options);
         $result = $result !== null ? (array) $result : null;
 
@@ -541,7 +534,6 @@ public function loadAll(array $criteria = [], ?array $sort = null, ?int $limit =
             $options['skip'] = $skip;
         }
 
-        assert($this->collection instanceof Collection);
         $baseCursor = $this->collection->find($criteria, $options);
 
         assert($baseCursor instanceof CursorInterface && $baseCursor instanceof SplIterator);
@@ -603,7 +595,6 @@ private function wrapCursor(SplIterator&CursorInterface $baseCursor): Iterator
     public function exists(object $document): bool
     {
         $id = $this->class->getIdentifierObject($document);
-        assert($this->collection instanceof Collection);
 
         return (bool) $this->collection->findOne(['_id' => $id], ['_id']);
     }
@@ -616,7 +607,7 @@ public function lock(object $document, int $lockMode): void
         $id          = $this->uow->getDocumentIdentifier($document);
         $criteria    = ['_id' => $this->class->getDatabaseIdentifierValue($id)];
         $lockMapping = $this->class->fieldMappings[$this->class->lockField];
-        assert($this->collection instanceof Collection);
+
         $this->collection->updateOne($criteria, ['$set' => [$lockMapping['name'] => $lockMode]]);
         $this->class->reflFields[$this->class->lockField]->setValue($document, $lockMode);
     }
@@ -629,7 +620,7 @@ public function unlock(object $document): void
         $id          = $this->uow->getDocumentIdentifier($document);
         $criteria    = ['_id' => $this->class->getDatabaseIdentifierValue($id)];
         $lockMapping = $this->class->fieldMappings[$this->class->lockField];
-        assert($this->collection instanceof Collection);
+
         $this->collection->updateOne($criteria, ['$unset' => [$lockMapping['name'] => true]]);
         $this->class->reflFields[$this->class->lockField]->setValue($document, null);
     }