Skip to content

Commit 389bb0f

Browse files
authored
Merge pull request #1254 from jdufresne/providing
Remove use of deprecated Signal.providing_args
2 parents bad48b2 + fb7c000 commit 389bb0f

File tree

3 files changed

+4
-8
lines changed

3 files changed

+4
-8
lines changed

debug_toolbar/panels/cache.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@
2020
tidy_stacktrace,
2121
)
2222

23-
cache_called = Signal(
24-
providing_args=["time_taken", "name", "return_value", "args", "kwargs", "trace"]
25-
)
23+
cache_called = Signal()
2624

2725

2826
def send_signal(method):

debug_toolbar/panels/signals.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class SignalsPanel(Panel):
3838

3939
def nav_subtitle(self):
4040
signals = self.get_stats()["signals"]
41-
num_receivers = sum(len(s[2]) for s in signals)
41+
num_receivers = sum(len(receivers) for name, receivers in signals)
4242
num_signals = len(signals)
4343
# here we have to handle a double count translation, hence the
4444
# hard coding of one signal
@@ -85,6 +85,6 @@ def generate_stats(self, request, response):
8585
else:
8686
text = receiver_name
8787
receivers.append(text)
88-
signals.append((name, signal, receivers))
88+
signals.append((name, receivers))
8989

9090
self.record_stats({"signals": signals})

debug_toolbar/templates/debug_toolbar/panels/signals.html

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,13 @@
33
<thead>
44
<tr>
55
<th>{% trans "Signal" %}</th>
6-
<th>{% trans "Providing" %}</th>
76
<th>{% trans "Receivers" %}</th>
87
</tr>
98
</thead>
109
<tbody>
11-
{% for name, signal, receivers in signals %}
10+
{% for name, receivers in signals %}
1211
<tr>
1312
<td>{{ name|escape }}</td>
14-
<td>{{ signal.providing_args|join:", " }}</td>
1513
<td>{{ receivers|join:", " }}</td>
1614
</tr>
1715
{% endfor %}

0 commit comments

Comments
 (0)