Skip to content

config editor doesn't update the internal state correctly when changing combobox (eg, affix and unique selection) with only keyboard inputs #501

Open
@slippycheeze

Description

@slippycheeze

I used the config editor to essentually create from scratch a profile, with quite some success. Thank you for adding it. After that, I happily loaded it, and then eventually wondered why my luck with drops was quite so awful.

It turned out that was because most of the items I'd entered were asking for two affixes from a pool of agility_cooldown_reduction, agility_cooldown_reduction, or agility_cooldown_reduction. Only the first two items, and the first affix of three on the third, were correct; the rest were agility_cooldown_reduction, the very first option offered by default in the combobox to select them.

This matches when I went from using the mouse to select the item to using the keyboard:

  1. click "add affix" on an item to add three
  2. tab into the first affix selector, which should be showing agility_cooldown_reduction
  3. type the start of something, eg, crit
  4. use the down arrow key to select the desired affix, eg critical_strike_chance
  5. hit enter to select it
  6. tab to the next affix selection and repeat

This shows, visually, the correct affix selections, but when saved it'll all be agility_cooldown_reduction in the YAML file. I assume this is because the internal "model" of the filter is updated on some sort of mouse related trigger, and misses the fact that it was changed using the keyboard. (possibly just using "enter" to select the full text is the trigger.)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions