Skip to content

[Discussion] Migration of testing framework from doctest to googletest #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mcbarton opened this issue Feb 14, 2025 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@mcbarton
Copy link
Collaborator

The following PR in CppInterOp compiler-research/CppInterOp#483 has shown GoogleTest to be a testing framework that works for both native and Emscripten builds (testing the Emscripten builds via node). Therefore switching from Doctest to GoogleTest would be beneficial, as it would allow for automated testing in both environments, and check that no changes to improve native builds, breaks the Emscripten build. It will also allow reviewers to check PRs more easily which claim to enable new features for xeus-cpp-lite, or whether a new feature being added for the native builds also works for the Emscripten build.

@github-actions github-actions bot added the Needs triage Used in auto labelling of new issues label Feb 14, 2025
@mcbarton mcbarton added enhancement New feature or request and removed Needs triage Used in auto labelling of new issues labels Feb 14, 2025
@SylvainCorlay
Copy link
Collaborator

From the Xeus team.

We were originally gtest users, but gtest is not very well maintained. We had reported obvious bugs with the maintainers and proposed fixes which were unfortunately ignored. This is the reason why we switched to doctest.

I also think that using the same framework and making xeus kernels as homogeneous as possible will also help long term sustainability and maintenance.

(For example, we will soon release xeus 6.0. If the changes are the same on all xeus kernels, it will make everyone's life easier.)

@anutosh491
Copy link
Collaborator

And I think now that xeus-cpp-lite can be tested pretty smoothly through doctest hosted on emscripten-forge as shown in #277 ... migration for the lite use case might not be hugely relevant unless gtest shows any concrete superior advantages.

mind that gtest is also hosted on emscripten-forge so not eliminating that as an option if it proves better in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants