Skip to content

Commit 760ceff

Browse files
committed
Rename gitlab's identifier for consistency's sake
I was going through our other test reporters to add gitlab CI support and noticed that ruby and python already have it, and identify it as "gitlab-ci". Seems best to identify it in the same way here.
1 parent cafd233 commit 760ceff

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/TestReporter/Entity/CiInfo.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ protected function werckerProperties(array $server)
188188
protected function gitlabCiProperties(array $server)
189189
{
190190
return array(
191-
"name" => "gitlabci",
191+
"name" => "gitlab-ci",
192192
"build_identifier" => $server["CI_BUILD_ID"],
193193
"branch" => $server["CI_BUILD_REF_NAME"],
194194
"commit_sha" => $server["CI_BUILD_REF"],

tests/Unit/TestReporter/Entity/CiInfoTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ public function testToArrayReturnsGitlabCiProperties()
214214
$info = new CiInfo($server);
215215

216216
$expected = array(
217-
'name' => 'gitlabci',
217+
'name' => 'gitlab-ci',
218218
'build_identifier' => $buildIdentifier,
219219
'branch' => $branch,
220220
'commit_sha' => $commitSha,

0 commit comments

Comments
 (0)