Update to Go 1.13 and use modules to track versions (#24)

Author: rogchap

Dockerfile

@@ -1,24 +1,28 @@
-FROM alpine:edge
+ARG BASE=1.13.1-alpine3.10
+FROM golang:${BASE} as build
 
+WORKDIR /usr/src/app
+
+COPY engine.json ./engine.json.template
+ RUN apk add --no-cache jq
+ RUN export go_version=$(go version | cut -d ' ' -f 3) && \
+     cat engine.json.template | jq '.version = .version + "/" + env.go_version' > ./engine.json
+
+COPY codeclimate-golint.go go.mod go.sum ./
+RUN apk add --no-cache git
+RUN go build -o codeclimate-golint .
+
+FROM golang:${BASE}
 LABEL maintainer="Code Climate <hello@codeclimate.com>"
 
 RUN adduser -u 9000 -D app
 
 WORKDIR /usr/src/app
 
-COPY engine.json /engine.json
-COPY codeclimate-golint.go /usr/src/app/codeclimate-golint.go
-
-RUN apk add --no-cache --virtual .dev-deps musl-dev go git && \
-  export GOPATH=/tmp/go GOBIN=/usr/local/bin && \
-  go get -d -t -v . && \
-  export LIBRARY_PATH=/usr/lib32:$LIBRARY_PATH && \
-  go install codeclimate-golint.go && \
-  apk del .dev-deps && \
-  rm -rf "$GOPATH"
+COPY --from=build /usr/src/app/engine.json /
+COPY --from=build /usr/src/app/codeclimate-golint ./
 
 USER app
-WORKDIR /code
 VOLUME /code
 
-CMD ["/usr/local/bin/codeclimate-golint"]
+CMD ["/usr/src/app/codeclimate-golint"]

Makefile

@@ -2,13 +2,5 @@
 
 IMAGE_NAME ?= codeclimate/codeclimate-golint
 
-update:
-	docker run \
-	  --rm --interactive \
-	  -v $(PWD)/engine.json:/engine.json \
-	  -v $(PWD)/bin/update:/usr/local/bin/update \
-	  alpine:edge \
-	  /usr/local/bin/update
-
-image: update
+image:
 	docker build --rm -t $(IMAGE_NAME) .

README.md

@@ -37,18 +37,6 @@ plugins:
 make image
 ```
 
-### Updating
-
-`golint` doesn't version releases, so in order to get the latest version & force
-a new docker image build, we have to update the `engine.json` file.
-
-```console
-make update
-```
-
-This will update the engine version with the latest `golint` version. After that
-rebuild the image as usually.
-
 ### Need help?
 
 For help with Golint, [check out their documentation](https://github.com/golang/lint).

bin/update

@@ -2,12 +2,13 @@ package main
 
 import (
 	"fmt"
-	"github.com/codeclimate/cc-engine-go/engine"
-	"github.com/golang/lint"
 	"io/ioutil"
 	"os"
 	"strconv"
 	"strings"
+
+	"github.com/codeclimate/cc-engine-go/engine"
+	"golang.org/x/lint"
 )
 
 const defaultMinConfidence = 0.8

codeclimate-golint.go

@@ -8,6 +8,6 @@
   "languages": [
     "Go"
   ],
-  "version": "1.0.0/6aaf7c34af0f4c36a57e0c429bace4d706d8e931",
+  "version": "1.0.0",
   "spec_version": "0.3.1"
 }

engine.json

@@ -0,0 +1,8 @@
+module github.com/codeclimate-community/codeclimate-golint
+
+go 1.13
+
+require (
+	github.com/codeclimate/cc-engine-go v0.0.0-20160217183426-55f9c825e2a9
+	golang.org/x/lint v0.0.0-20190930215403-16217165b5de
+)

go.mod

@@ -0,0 +1,10 @@
+github.com/codeclimate/cc-engine-go v0.0.0-20160217183426-55f9c825e2a9 h1:Wk8UDfEjmZtZI8guLovZZ1QXkbGIPWy2cpeYS2JgKPg=
+github.com/codeclimate/cc-engine-go v0.0.0-20160217183426-55f9c825e2a9/go.mod h1:A0vs4JxevyA0WJrMjU/5sedZBlICgsdPloAKENM2JmU=
+golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
+golang.org/x/lint v0.0.0-20190930215403-16217165b5de h1:5hukYrvBGR8/eNkX5mdUezrA6JiaEZDtJb9Ei+1LlBs=
+golang.org/x/lint v0.0.0-20190930215403-16217165b5de/go.mod h1:6SW0HCj/g11FgYtHlgUYUwCkIfeOF89ocIRzGO/8vkc=
+golang.org/x/net v0.0.0-20190311183353-d8887717615a/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
+golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
+golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
+golang.org/x/tools v0.0.0-20190311212946-11955173bddd h1:/e+gpKk9r3dJobndpTytxS2gOy6m5uvpg+ISQoEcusQ=
+golang.org/x/tools v0.0.0-20190311212946-11955173bddd/go.mod h1:LCzVGOaR6xXOjkQ3onu1FJEFr0SW1gC7cKk1uF8kGRs=