Skip to content

Commit cc46f5a

Browse files
committed
Update hls.js to its latest version
Bumped from 0.14.17 to 1.2.4. Didn't test extensively, but playback seems fine, only noticed an issue with captions, which seems to be related to #18 Bumping as a major to avoid this version being picked up by the other packages, since most I saw are pulling minors lint
1 parent 4fc9279 commit cc46f5a

File tree

3 files changed

+1007
-1040
lines changed

3 files changed

+1007
-1040
lines changed

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@clappr/hlsjs-playback",
3-
"version": "0.6.0",
3+
"version": "1.0.0",
44
"description": "HLS Playback based on hls.js",
55
"main": "./dist/hlsjs-playback.js",
66
"module": "./dist/hlsjs-playback.esm.js",
@@ -36,7 +36,7 @@
3636
"homepage": "https://github.com/clappr/hlsjs-playback",
3737
"peerDependencies": {
3838
"@clappr/core": "^0.4.18",
39-
"hls.js": "^0.14.17"
39+
"hls.js": "^1.2.4"
4040
},
4141
"devDependencies": {
4242
"@babel/core": "^7.14.2",
@@ -50,7 +50,7 @@
5050
"coveralls": "^3.1.0",
5151
"cz-conventional-changelog": "^3.3.0",
5252
"eslint": "^7.26.0",
53-
"hls.js": "^0.14.17",
53+
"hls.js": "^1.2.4",
5454
"jest": "^26.6.3",
5555
"rollup": "^2.47.0",
5656
"rollup-plugin-filesize": "^9.1.1",

src/hls.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,14 +164,14 @@ describe('HlsjsPlayback', () => {
164164
const playback = new HlsjsPlayback({ src: 'http://clappr.io/foo.m3u8', hlsPlayback: { preload: false } })
165165
playback._setup()
166166
jest.spyOn(playback._hls, 'loadSource')
167-
playback._hls.trigger(HLSJS.Events.MEDIA_ATTACHED)
167+
playback._hls.trigger(HLSJS.Events.MEDIA_ATTACHED, { media: playback.el })
168168

169169
expect(playback._hls.loadSource).not.toHaveBeenCalled()
170170

171171
playback.options.hlsPlayback.preload = true
172172
playback._setup()
173173
jest.spyOn(playback._hls, 'loadSource')
174-
playback._hls.trigger(HLSJS.Events.MEDIA_ATTACHED)
174+
playback._hls.trigger(HLSJS.Events.MEDIA_ATTACHED, { media: playback.el })
175175

176176
expect(playback._hls.loadSource).toHaveBeenCalledTimes(1)
177177
})
@@ -182,7 +182,7 @@ describe('HlsjsPlayback', () => {
182182
expect(playback._manifestParsed).toBeUndefined()
183183

184184
playback._setup()
185-
playback._hls.trigger(HLSJS.Events.MANIFEST_PARSED)
185+
playback._hls.trigger(HLSJS.Events.MANIFEST_PARSED, { levels: [] })
186186

187187
expect(playback._manifestParsed).toBeTruthy()
188188
})
@@ -275,7 +275,7 @@ describe('HlsjsPlayback', () => {
275275

276276
expect(cb).toHaveBeenCalledTimes(1)
277277

278-
playback._hls.trigger(HLSJS.Events.MEDIA_ATTACHING)
278+
playback._hls.trigger(HLSJS.Events.MEDIA_ATTACHING, { media: playback.el })
279279

280280
expect(cb).toHaveBeenCalledTimes(2)
281281
})

0 commit comments

Comments
 (0)