Refactoring of rehace-github-magnolia

[janroesler]

I have created this issue to discuss the refactoring for rehace-github-magnolia @pbit
mentioned in burning-duck/burning-duck#11

[janroesler]

I think it would be nice if the module has both.

• Pages for list and detail, ready to use
• Pure components for a flexible usage

[pbit]

@janroesler
Ok, so we split it?

• keep a simple list and detail page one can use as reference implementation.
• create standalone components ready to be included into an existing page

[janroesler]

Yah and under the hood we can reuse the .yaml and .ftl files with include or decorations.

[janroesler]

Have @topherzee or @abduld any idea? ;)

[topherzee]

Sorry for the late response. Yes, I like the idea of providing component templates. I see some value in the page templates as well. If you want to provide similar templating code to both, another mechanism at your disposal is to use is FTL macros and FTL includes - they might be more relevant than YAML include or decorations. (Maybe that's what you were already getting at above.)

On the other hand if the page templates are just there for demo purposes, you could consider dropping them and just use the MTK basic page and provide some bootstraps (as you did) of pages with the components on them. To get the resources in - as a kind of hack for the demo you can include an HTML component with the resources linked to.
Im not recommending you change to this approach - just an option.

[janroesler]

Hey, a late response is better than no response 😉

At this point the list page has no special page properties. So this would bee a simple refactoring to get only components for this.

But the list page is looking trough his child pages and checks if the child is a project detail page to get the page properties. I have no idea how to make components from that, how would the list component get the props from the project detail components on the child page, same page, parent page or from another tree.

Solutions:
Create a component that has the needed detail props (repo name / project name) and this component creates an area and in this all detail components get added? Than the list page checks his for this area? And the list component gets an multivalue link field, so you can add each detail page from anywhere?

I don't think that the page templates are only for demo. A out of the box solution would be grate. But i don't know if the pages make any sense if we have all packt in components 🤔

hmmmm . . . 😄