Merge pull request #70 from bcuff/so-fix

fix: stack overflow in Dispose method

Author: bcuff

src/Elasticsearch.Net.Aws/ElasticSearch.Net.Aws.Tests/SigningHttpMessageHandlerTests.cs

@@ -0,0 +1,44 @@
+using System;
+using System.Diagnostics;
+using System.Globalization;
+using System.Net.Http;
+using System.Text;
+using System.Threading;
+using System.Threading.Tasks;
+using Amazon.Runtime;
+using Elasticsearch.Net.Aws;
+using NUnit.Framework;
+using Elasticsearch.Net;
+using System.IO;
+using Amazon;
+#if NETFRAMEWORK
+using System.Net;
+#endif
+
+namespace Tests
+{
+    [TestFixture]
+    public class SigningHttpMessageHandlerTests
+    {
+        private class TestHandler : HttpClientHandler
+        {
+            public bool Disposed;
+            protected override void Dispose(bool disposing)
+            {
+                base.Dispose(disposing);
+                Disposed = true;
+            }
+        }
+
+#if NETCOREAPP
+        [Test]
+        public void TestDispose()
+        {
+            var inner = new TestHandler();
+            var outer = new SigningHttpMessageHandler(new BasicAWSCredentials("foo", "bar"), RegionEndpoint.USEast1, inner);
+            outer.Dispose();
+            Assert.AreEqual(true, inner.Disposed);
+        }
+#endif
+    }
+}

src/Elasticsearch.Net.Aws/Elasticsearch.Net.Aws/Elasticsearch.Net.Aws.csproj

@@ -4,13 +4,13 @@
     <TargetFrameworks>netstandard2.0;net461</TargetFrameworks>
     <AssemblyName>Elasticsearch.Net.Aws</AssemblyName>
     <PackageId>Elasticsearch.Net.Aws</PackageId>
-    <Version>7.2.0</Version>
+    <Version>7.2.1</Version>
     <Authors>Brandon Cuff</Authors>
     <Description>Enables request signing necessary for using the AWS Elasticsearch service.</Description>
     <Copyright>Copyright 2015</Copyright>
     <PackageLicenseUrl>https://raw.githubusercontent.com/bcuff/elasticsearch-net-aws/master/LICENSE</PackageLicenseUrl>
     <PackageProjectUrl>https://github.com/bcuff/elasticsearch-net-aws</PackageProjectUrl>
-    <PackageReleaseNotes>Fix to support HTTP compression.</PackageReleaseNotes>
+    <PackageReleaseNotes>Fixed stack overflow in Dispose method.</PackageReleaseNotes>
     <PackageTags>elasticsearch elastic search aws amazon</PackageTags>
     <RepositoryUrl>https://github.com/bcuff/elasticsearch-net-aws</RepositoryUrl>
   </PropertyGroup>

src/Elasticsearch.Net.Aws/Elasticsearch.Net.Aws/SigningHttpMessageHandler.cs

@@ -41,7 +41,7 @@ protected override void Dispose(bool disposing)
                 }
                 _innerHandlerDisposed = true;
             }
-            base.Dispose();
+            base.Dispose(disposing);
         }
     }
 }