Remove JS SDK v2 examples (#222)

Author: trivikr

.github/ISSUE_TEMPLATE/bug_report.md

@@ -1,33 +1,37 @@
 ---
 name: Bug report
 about: Create a report to help us improve
-title: ''
-labels: ''
-assignees: ''
-
+title: ""
+labels: ""
+assignees: ""
 ---
 
 <!--
 This template is for cutting bugs with aws-sdk-js-tests package.
-Use the following links for creating bugs with AWS JS SDK v2/v3:
-* v2 https://github.com/aws/aws-sdk-js/issues/new/choose
-* v3 https://github.com/aws/aws-sdk-js-v3/issues/new/choose
+Use the following link for creating bugs with AWS SDK for JavaScript:
+* https://github.com/aws/aws-sdk-js-v3/issues/new/choose
 -->
 
 ## Describe the bug
+
 A clear and concise description of what the bug is.
 
 ## Steps to reproduce
+
 Steps to reproduce the behavior.
 
 #### Observed behavior
+
 A clear and concise description of what happens.
 
 #### Expected behavior
+
 A clear and concise description of what you were expecting to happen.
 
 #### Screenshots
+
 If applicable, add screenshots to help explain your problem.
 
 ## Additional context
+
 Add any other context about the problem here.

.github/ISSUE_TEMPLATE/feature_request.md

@@ -1,27 +1,29 @@
 ---
 name: Feature request
 about: Suggest an idea for this project
-title: ''
-labels: ''
-assignees: ''
-
+title: ""
+labels: ""
+assignees: ""
 ---
 
 <!--
 This template is for creating feature requests with aws-sdk-js-tests package.
-Use the following links for creating feature requests with AWS JS SDK v2/v3:
-* v2 https://github.com/aws/aws-sdk-js/issues/new/choose
-* v3 https://github.com/aws/aws-sdk-js-v3/issues/new/choose
+Use the following link for creating feature request with AWS SDK for JavaScript:
+* https://github.com/aws/aws-sdk-js-v3/issues/new/choose
 -->
 
 ### Is your feature request related to a problem? Please describe.
+
 A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
 
 ### Describe the solution you'd like
+
 A clear and concise description of what you want to happen.
 
 ### Describe alternatives you've considered
+
 A clear and concise description of any alternative solutions or features you've considered.
 
 ### Additional context
+
 Add any other context or screenshots about the feature request here.

README.md

@@ -15,9 +15,9 @@ Code Samples for testing AWS SDK for JavaScript.
 - Run `corepack enable` to let corepack manage version of yarn.
 - Update REGION in [`packages/utils/src/config.js`](./packages/utils/src/config.js).
 - For browser and react-native, IDENTITY_POOL_ID also needs to be updated.
-  - [Create a Amazon Cognito Identity pool for testing](https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/getting-started-browser.html#getting-started-browser-create-identity-pool)
+  - [Create a Amazon Cognito Identity pool for testing](https://docs.aws.amazon.com/sdk-for-javascript/v3/developer-guide/getting-started-browser.html#getting-started-browser-create-identity-pool)
     - Note down IDENTITY_POOL_ID
-  - [Add a Policy to the test Unauthenticated IAM Role](https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/getting-started-browser.html#getting-started-browser-iam-role)
+  - [Add a Policy to the test Unauthenticated IAM Role](https://docs.aws.amazon.com/sdk-for-javascript/v3/developer-guide/getting-started-browser.html#getting-started-browser-iam-role)
     - The policy should be specific to the operations you want to test
   - Update the IDENTITY_POOL_ID in [`packages/utils/src/config.js`](./packages/utils/src/config.js).
 
@@ -28,7 +28,7 @@ Code Samples for testing AWS SDK for JavaScript.
 
 ### Node.js:
 
-- Run `yarn start:node` to run both v2 and v3 clients in Node.js
+- Run `yarn start:node` to run SDK clients in Node.js
 - The responses returned by clients will be printed in console, and will re-run when code is updated.
 - The file being run is at [`packages/node/src/index.js`](./packages/node/src/index.js).
 

img/screenshot-android.png

@@ -1,13 +1,9 @@
-import { REGION, getV2Response, getV3Response } from "@aws-sdk/test-utils";
+import { REGION, getResponse } from "@aws-sdk/test-utils";
 
 (async () => {
   let response;
 
-  response = await getV2Response({ region: REGION });
-  console.log("Data returned by v2:");
-  console.log(JSON.stringify(response, null, 2));
-
-  response = await getV3Response({ region: REGION });
-  console.log("\nData returned by v3:");
+  response = await getResponse({ region: REGION });
+  console.log("\nData returned:");
   console.log(JSON.stringify(response, null, 2));
 })();

img/screenshot-ios.png

@@ -17,52 +17,31 @@ import 'react-native-get-random-values';
 import 'react-native-url-polyfill/auto';
 import 'web-streams-polyfill/dist/polyfill';
 
-import {getV2BrowserResponse, getV3BrowserResponse} from '@aws-sdk/test-utils';
+import {getBrowserResponse} from '@aws-sdk/test-utils';
 
 const App: () => Node = () => {
-  const [v2Response, setV2Response] = useState('');
-  const [v3Response, setV3Response] = useState('');
+  const [response, setResponse] = useState('');
 
-  const fetchV2Response = async () => {
+  const fetchResponse = async () => {
     try {
-      const v2Response = await getV2BrowserResponse();
-      setV2Response(JSON.stringify(v2Response, null, 2));
+      const response = await getBrowserResponse();
+      setResponse(JSON.stringify(response, null, 2));
     } catch (err) {
       console.error(serializeError(err));
-      setV2Response(`Error: ${err}. Check console for more details.`);
-    }
-  };
-
-  const fetchV3Response = async () => {
-    try {
-      const v3Response = await getV3BrowserResponse();
-      setV3Response(JSON.stringify(v3Response, null, 2));
-    } catch (err) {
-      console.error(serializeError(err));
-      setV3Response(`Error: ${err}. Check console for more details.`);
+      setResponse(`Error: ${err}. Check console for more details.`);
     }
   };
 
   return (
     <View style={styles.container}>
       <View style={styles.sectionContainer}>
-        <Text style={styles.sectionTitle}>AWS SDK for JavaScript (v2):</Text>
-        <Button title="Call with v2" onPress={fetchV2Response} />
-        <TextInput
-          style={styles.sectionDescription}
-          multiline={true}
-          placeholder="v2 response will be populated here"
-          value={v2Response}
-        />
-      </View>
-      <View style={styles.sectionContainer}>
-        <Text style={styles.sectionTitle}>AWS SDK for JavaScript (v3):</Text>
-        <Button title="Call with v3" onPress={fetchV3Response} />
+        <Text style={styles.sectionTitle}>AWS SDK for JavaScript:</Text>
+        <Button title="Click to make a call" onPress={fetchResponse} />
         <TextInput
           style={styles.sectionDescription}
           multiline={true}
-          placeholder="v3 response will be populated here"
-          value={v3Response}
+          placeholder="Response will be populated here"
+          value={response}
         />
       </View>
     </View>

img/screenshot-node.png

@@ -7,8 +7,7 @@
   "dependencies": {
     "@aws-sdk/client-cognito-identity": "^3.540.0",
     "@aws-sdk/client-dynamodb": "^3.540.0",
-    "@aws-sdk/credential-provider-cognito-identity": "^3.540.0",
-    "aws-sdk": "^2.1588.0"
+    "@aws-sdk/credential-provider-cognito-identity": "^3.540.0"
   },
   "author": {
     "name": "AWS SDK for JavaScript Team",

img/screenshot-web.png

@@ -1,33 +1,16 @@
-import AWS from "aws-sdk";
-
 import { fromCognitoIdentityPool } from "@aws-sdk/credential-provider-cognito-identity";
 import { CognitoIdentityClient } from "@aws-sdk/client-cognito-identity";
 import { DynamoDB } from "@aws-sdk/client-dynamodb";
 
 import { REGION, IDENTITY_POOL_ID } from "./config.js";
 
-export const getV2Response = async (clientParams) => {
-  const client = new AWS.DynamoDB(clientParams);
-  return client.listTables({ Limit: 1 }).promise();
-};
-
-export const getV3Response = async (clientParams) => {
+export const getResponse = async (clientParams) => {
   const client = new DynamoDB(clientParams);
   return client.listTables({ Limit: 1 });
 };
 
-export const getV2BrowserResponse = async () => {
-  // Initialize the Amazon Cognito credentials provider
-  AWS.config.region = REGION;
-  AWS.config.credentials = new AWS.CognitoIdentityCredentials({
-    IdentityPoolId: IDENTITY_POOL_ID,
-  });
-
-  return getV2Response({ region: REGION });
-};
-
-export const getV3BrowserResponse = async () =>
-  getV3Response({
+export const getBrowserResponse = async () =>
+  getResponse({
     region: REGION,
     credentials: fromCognitoIdentityPool({
       client: new CognitoIdentityClient({

packages/node/src/index.js

@@ -1,7 +1,4 @@
-import {
-  getV2BrowserResponse,
-  getV3BrowserResponse,
-} from "@aws-sdk/test-utils";
+import { getBrowserResponse } from "@aws-sdk/test-utils";
 
 const getHTMLElement = (title, content) => {
   const element = document.createElement("div");
@@ -20,24 +17,11 @@ const getHTMLElement = (title, content) => {
   return element;
 };
 
-const componentV2 = async () => {
-  const response = await getV2BrowserResponse();
-  return getHTMLElement(
-    "Data returned by v2:",
-    JSON.stringify(response, null, 2)
-  );
-};
-
-const componentV3 = async () => {
-  const response = await getV3BrowserResponse();
-
-  return getHTMLElement(
-    "Data returned by v3:",
-    JSON.stringify(response, null, 2)
-  );
+const component = async () => {
+  const response = await getBrowserResponse();
+  return getHTMLElement("Data returned:", JSON.stringify(response, null, 2));
 };
 
 (async () => {
-  document.body.appendChild(await componentV2());
-  document.body.appendChild(await componentV3());
+  document.body.appendChild(await component());
 })();