Better test pagination and fix bug

Author: cwood

pagination.go

@@ -23,13 +23,13 @@ func NewLink(linkheader string) *Link {
 	link := &Link{}
 	links := strings.SplitN(linkheader, ",", 2)
 	for _, page := range links {
-		data := strings.SplitN(page, ";", 3)
+		data := strings.SplitN(page, ";", 4)
 
-		pagelink := strings.TrimLeft(data[0], "<")
+		pagelink := strings.TrimLeft(strings.TrimSpace(data[0]), "<")
 		pagelink = strings.TrimRight(pagelink, ">")
 
-		pagetype := strings.Trim(strings.Split(data[1], "=")[1], "\"")
-		results, err := strconv.ParseBool(strings.Split(data[2], "=")[1])
+		pagetype := strings.Trim(strings.Split(data[1], "=")[1], `"`)
+		results, err := strconv.ParseBool(strings.Trim(strings.Split(strings.TrimSpace(data[2]), "=")[1], `"`))
 		if err != nil {
 			results = false
 		}

pagination_test.go

@@ -0,0 +1,28 @@
+package sentry
+
+import (
+	"testing"
+)
+
+func TestLinkPagination(t *testing.T) {
+	examplelink := `<https://sentry.io/api/0/projects/the-interstellar-jurisdiction/pump-station/releases/?&cursor=100:-1:1>; rel="previous"; results="true"; cursor="100:-1:1", <https://sentry.io/api/0/projects/the-interstellar-jurisdiction/pump-station/releases/?&cursor=100:1:0>; rel="next"; results="true"; cursor="100:1:0`
+
+	link := NewLink(examplelink)
+
+	if link.Next.URL != "https://sentry.io/api/0/projects/the-interstellar-jurisdiction/pump-station/releases/?&cursor=100:1:0" {
+		t.Errorf("Link next isnt correct: %s", link.Next.URL)
+	}
+
+	if link.Previous.URL != "https://sentry.io/api/0/projects/the-interstellar-jurisdiction/pump-station/releases/?&cursor=100:-1:1" {
+		t.Errorf("Link previous isnt correct: %s", link.Previous.URL)
+	}
+
+	if !link.Next.Results {
+		t.Error("Results should be set to true for next")
+	}
+
+	if !link.Previous.Results {
+		t.Error("Results should be set to true for previous")
+	}
+
+}