Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: arrayfire/arrayfire-haskell
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.7.0.0
Choose a base ref
...
head repository: arrayfire/arrayfire-haskell
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 6 commits
  • 33 files changed
  • 3 contributors

Commits on Mar 26, 2023

  1. Fix tests for ArrayFire 3.8.3 (#51)

    * Do not rely on == comparison for cbrt and sqrt tests
    
    * Do not be too strict about the version constraint; upstream ArrayFire changes a lot between minor releases, so we check for that, but don't assert a specific patch version
    twesterhout authored Mar 26, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    5e69254 View commit details

Commits on Aug 24, 2023

  1. Switch to Nix flakes; make the tests pass with newest ArrayFire (#55)

    * Switch to Nix flakes; make the tests pass with nix build & nix develop for the latest version of ArrayFire
    
    * update flake.lock
    twesterhout authored Aug 24, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    1e4f909 View commit details

Commits on Aug 25, 2023

  1. Fix joinMany (#56)

    Instead of allocating an array of pointers, joinMany was allocating
    memory for just one pointer. This was making ArrayFire read out of
    bounds and fail with various errors.
    
    This commit fixes this issue by adding a helper withManyForeignPtr
    function that acts like withForeignPtr (not unsafeWithForeignPtr!), but
    for a list of ForeignPtrs.
    twesterhout authored Aug 25, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    90812e0 View commit details
  2. Fix (**) and use property tests (#57)

    The default implementation of (**) relied on log and incorrectly
    handled some inputs. The fix is making an explicit implementation
    using the pow function.
    
    To test the changes, tests for functions from the Floating typeclass
    are re-written using property tests. There are a few helper functions
    to make writing the actual properties easy.
    
    More tests can be converted to properties, but this is left for
    another PR.
    twesterhout authored Aug 25, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    971bae0 View commit details

Commits on May 4, 2024

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    f268fc9 View commit details

Commits on Dec 14, 2024

  1. Verified

    This commit was signed with the committer’s verified signature.
    Copy the full SHA
    fa74dd8 View commit details
Loading