Regression v143->v144: crash loading MSX roms with '--system MSX' (not MSX2)

[wstephenson]

Describe the bug
Since v144, Ares crashes when launching MSX roms with --system MSX. The Ares window appears with the moon splash, the moon disappears, and the window closes. When launching with --system MSX2, the rom loads normally.

To Reproduce
Steps to reproduce the behavior:

1. cd to Ares installation folder in Windows Terminal or PowerShell
2. Enter `.\ares.exe --system MSX ..\path\to\nemesis.rom (other roms also exhibit this behaviour, both SCC and non-SCC)
3. Output:

PS C:\Games\Emulation\ares-v144> .\ares.exe --system MSX ..\emu_roms\msx\roms\nemesis.rom
PS C:\Games\Emulation\ares-v144> Loaded nemesis
[unimplemented] [CPU::out] port: ab = 82

5. Ares window closes

Expected behavior
Game runs. With v143 output is:

PS .\ares.exe --system MSX ..\emu_roms\msx\roms\nemesis.rom
PS C:\Games\Emulation\ares-v143> Loaded nemesis
[unimplemented] [CPU::out] port: ab = 82
[unimplemented] [CPU::out] port: 90 = ff
[unimplemented] [CPU::in] port: aa

and the game runs.

With v143 and --system MSX2, output is:

PS C:\Games\Emulation\ares-v144> .\ares.exe --system MSX2 ..\emu_roms\msx\roms\nemesis.rom
PS C:\Games\Emulation\ares-v144> Loaded nemesis
[unimplemented] [CPU::out] port: bb = 08
[unimplemented] [CPU::out] port: ab = 82
[unimplemented] [CPU::out] port: 90 = ff
[unimplemented] [CPU::out] port: f7 = d3
[unimplemented] [CPU::out] port: f8 = 00
[unimplemented] [CPU::out] port: d8 = 00
[unimplemented] [CPU::out] port: d9 = 02
[unimplemented] [CPU::in] port: d9
[unimplemented] [CPU::in] port: c0
[unimplemented] [CPU::in] port: f7
[unimplemented] [CPU::in] port: c8
[unimplemented] [CPU::out] port: 81 = 00
[unimplemented] [CPU::out] port: 81 = 40
[unimplemented] [CPU::in] port: 81
[unimplemented] [CPU::in] port: bb
[unimplemented] [CPU::out] port: f5 = ff
[unimplemented] [RTC::write] bank: 0 index: 14 = 0
[unimplemented] [RTC::write] bank: 0 index: 15 = 13
[unimplemented] [RTC::write] bank: 1 index: 10 = 1
[unimplemented] [CPU::in] port: ba
[unimplemented] [CPU::in] port: aa

and the game runs.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
OS: Windows 11 Home 24H2
GPU RTX 3060 12GB
Processor AMD Ryzen 9 5900X 12-Core Processor 3.70 GHz
Installed RAM 32.0 GB (31.9 GB usable)
Product ID 00326-10000-00000-AA959
System type 64-bit operating system, x64-based processor
Pen and touch No pen or touch input is available for this display

[jcm93]

Does this issue occur when loading the same ROM via the user interface instead of on the command line?

[wstephenson]

Yes, the UI window closes. If I run ares from a terminal and start the emulation via the UI, I get the same output as in the first code block above.

Sorry for the delay in replying, so many GH notifications, so little time to play!