[Feature] Ensure Group Service Type (#1887)

Author: ajanikow

CHANGELOG.md

@@ -4,6 +4,7 @@
 - (Maintenance) Optimize go.mod
 - (Bugfix) Prevent UpToDate Condition changes during Action processing
 - (Feature) (Platform) Reorganize Envoy Auth
+- (Feature) Ensure Group Service Type
 
 ## [1.2.48](https://github.com/arangodb/kube-arangodb/tree/1.2.48) (2025-05-08)
 - (Maintenance) Extend Documentation

pkg/deployment/resources/services.go

@@ -160,7 +160,7 @@ func (r *Resources) EnsureServices(ctx context.Context, cachedStatus inspectorIn
 			ports := []core.ServicePort{CreateServerServicePort()}
 			// Service should exists
 			if !ok {
-				s := r.createService(name, apiObject.GetNamespace(), spec.CommunicationMethod.ServiceClusterIP(), spec.CommunicationMethod.ServiceType(), false, apiObject.AsOwner(), ports, selector)
+				s := r.createService(name, apiObject.GetNamespace(), "", core.ServiceTypeClusterIP, false, apiObject.AsOwner(), ports, selector)
 
 				err := globals.GetGlobalTimeouts().Kubernetes().RunWithTimeout(ctx, func(ctxChild context.Context) error {
 					_, err := svcs.Create(ctxChild, s, meta.CreateOptions{})
@@ -175,14 +175,26 @@ func (r *Resources) EnsureServices(ctx context.Context, cachedStatus inspectorIn
 				reconcileRequired.Required()
 				continue
 			} else {
-				if _, changed, err := patcher.Patcher[*core.Service](ctx, svcs, s, meta.PatchOptions{},
-					patcher.PatchServicePorts(ports),
-					patcher.PatchServiceSelector(selector),
-					patcher.PatchServicePublishNotReadyAddresses(false),
-					patcher.PatchServiceType(spec.CommunicationMethod.ServiceType())); err != nil {
-					return err
-				} else if changed {
-					reconcileRequired.Required()
+				if s.Spec.ClusterIP == core.ClusterIPNone {
+					// Recreation required
+					if err := globals.GetGlobalTimeouts().Kubernetes().RunWithTimeout(ctx, func(ctxChild context.Context) error {
+						return svcs.Delete(ctxChild, s.GetName(), meta.DeleteOptions{})
+					}); err != nil {
+						if !kerrors.IsNotFound(err) {
+							return err
+						}
+						reconcileRequired.Required()
+					}
+				} else {
+					if _, changed, err := patcher.Patcher[*core.Service](ctx, svcs, s, meta.PatchOptions{},
+						patcher.PatchServicePorts(ports),
+						patcher.PatchServiceSelector(selector),
+						patcher.PatchServicePublishNotReadyAddresses(false),
+						patcher.PatchServiceType(core.ServiceTypeClusterIP)); err != nil {
+						return err
+					} else if changed {
+						reconcileRequired.Required()
+					}
 				}
 			}
 		}