Skip to content

Commit f265238

Browse files
committed
Update tests.
1 parent 490ae41 commit f265238

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

Tests/SwiftProtobufTests/Test_TextFormat_proto3.swift

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -367,13 +367,9 @@ final class Test_TextFormat_proto3: XCTestCase, PBTestHelpers {
367367
(o: MessageTestType) in
368368
return o.optionalFloat == 0.0 && o.optionalFloat.sign == .plus
369369
}
370-
// The negative version won't really round trip, because -0.0 for proto3 counts as not set.
371-
do {
372-
let msg = try MessageTestType(textFormatString: "optional_float: -1e-50\n")
373-
XCTAssertEqual(msg.optionalFloat, 0.0)
374-
XCTAssertEqual(msg.optionalFloat.sign, .minus)
375-
} catch {
376-
XCTFail("Shouldn't have thrown on decode: \(error)")
370+
assertTextFormatDecodeSucceeds("optional_float: -1e-50\n") {
371+
(o: MessageTestType) in
372+
return o.optionalFloat == 0.0 && o.optionalFloat.sign == .minus
377373
}
378374
// protobuf conformance requires subnormals to be handled
379375
assertTextFormatDecodeSucceeds("optional_float: 1.17549e-39\n") {
@@ -512,13 +508,9 @@ final class Test_TextFormat_proto3: XCTestCase, PBTestHelpers {
512508
(o: MessageTestType) in
513509
return o.optionalDouble == 0.0 && o.optionalDouble.sign == .plus
514510
}
515-
// The negative version won't really round trip, because -0.0 for proto3 counts as not set.
516-
do {
517-
let msg = try MessageTestType(textFormatString: "optional_double: -1e-9999\n")
518-
XCTAssertEqual(msg.optionalDouble, 0.0)
519-
XCTAssertEqual(msg.optionalDouble.sign, .minus)
520-
} catch {
521-
XCTFail("Shouldn't have thrown on decode: \(error)")
511+
assertTextFormatDecodeSucceeds("optional_double: -1e-9999\n") {
512+
(o: MessageTestType) in
513+
return o.optionalDouble == 0.0 && o.optionalDouble.sign == .minus
522514
}
523515
assertTextFormatDecodeSucceeds("optional_double: INFINITY\n") {(o: MessageTestType) in
524516
return o.optionalDouble == Double.infinity

0 commit comments

Comments
 (0)