You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make dependencies.py generate fail on cargo-deny error (#1366)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes#123` indicates that this PR will close issue #123.
-->
- Related to #1325.
## What changes are included in this PR?
<!--
Provide a summary of the modifications in this PR. List the main changes
such as new features, bug fixes, refactoring, or any other updates.
-->
`DEPENDENCIES.rust.tsv` files were accidentally removed as part of the
0.5.0 prep PR (#1345). It was added back and updated in the follow up PR
(#1363).
I realized this happened because I did not install `cargo-deny` in my
env and the dependency generation script did not error.
This PR changes generation script (`python3 ./scripts/dependencies.py
generate`) to error when the underlying subprocess call (`cargo deny`)
errors.
I also ran `uvx ruff format scripts/dependencies.py` to format the
script
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
Yes, manually
I was also able to install `cargo-deny` and confirm #1363 changes are
all correct
```
cargo install --locked cargo-deny
```
0 commit comments