chore: Add assertion for empty data files for append action (#1301)

## What changes are included in this PR?

The general usage to append data files is
```rust
let mut action = txn.fast_append(/*commit_uuid=*/ None, /*key_metadata=*/ vec![])?;
action.add_data_files(new_data_files)?;
let txn = action.apply().await?;
let table = txn.commit(catalog).await?
```
I found if ` new_data_files` is empty by accident, a new manifest file
will still be created and tracked by manifest list file, which doesn't
make sense to me (let me if team thinks it's a valid and ideal use
case).

In this PR, I did a few changes:
- Add a new invalid argument error code;
- Add assertion to fail empty data files append, and empty action commit
use cases.

## Are these changes tested?

Existing unit tests pass, and add a validation test for invalid data
file append.

Author: dentiny

crates/iceberg/src/error.rs

@@ -28,6 +28,9 @@ pub type Result<T> = std::result::Result<T, Error>;
 #[derive(Clone, Copy, Debug, PartialEq, Eq)]
 #[non_exhaustive]
 pub enum ErrorKind {
+    /// The operation was rejected because the system is not in a state required for the operation’s execution.
+    PreconditionFailed,
+
     /// Iceberg don't know what happened here, and no actions other than
     /// just returning it back. For example, iceberg returns an internal
     /// service error.
@@ -76,6 +79,7 @@ impl From<ErrorKind> for &'static str {
             ErrorKind::TableNotFound => "TableNotFound",
             ErrorKind::NamespaceAlreadyExists => "NamespaceAlreadyExists",
             ErrorKind::NamespaceNotFound => "NamespaceNotFound",
+            ErrorKind::PreconditionFailed => "PreconditionFailed",
         }
     }
 }

crates/iceberg/src/transaction/append.rs

@@ -219,6 +219,15 @@ mod tests {
     use crate::transaction::Transaction;
     use crate::{TableRequirement, TableUpdate};
 
+    #[tokio::test]
+    async fn test_empty_data_append_action() {
+        let table = make_v2_minimal_table();
+        let tx = Transaction::new(&table);
+        let mut action = tx.fast_append(None, vec![]).unwrap();
+        action.add_data_files(vec![]).unwrap();
+        assert!(action.apply().await.is_err());
+    }
+
     #[tokio::test]
     async fn test_fast_append_action() {
         let table = make_v2_minimal_table();

crates/iceberg/src/transaction/snapshot.rs

@@ -172,6 +172,13 @@ impl<'a> SnapshotProduceAction<'a> {
     // Write manifest file for added data files and return the ManifestFile for ManifestList.
     async fn write_added_manifest(&mut self) -> Result<ManifestFile> {
         let added_data_files = std::mem::take(&mut self.added_data_files);
+        if added_data_files.is_empty() {
+            return Err(Error::new(
+                ErrorKind::PreconditionFailed,
+                "No added data files found when write a manifest file",
+            ));
+        }
+
         let snapshot_id = self.snapshot_id;
         let format_version = self.tx.current_table.metadata().format_version();
         let manifest_entries = added_data_files.into_iter().map(|data_file| {