Upgrade golangci-lint to v2

[antoninbas]

golangci-lint has had a major version bump to v2
we should migrate to this new version
there is a migration guide available: https://golangci-lint.run/product/migration-guide/

[petertran-avgo]

Hey @antoninbas - I've been chipping away at this for a week now. Could I get your advice?

So far I've addressed all the staticcheck errors (on this branch https://github.com/petertran-avgo/antrea/commits/7093-bump-golang-ci-lint-v2/ ) which is pretty large.

There are 1157 remaining gosec issues:

• 1113 of them are G104:

Errors unhandled (gosec)

Which is when a method returns an error but we don't check it. Here's an example:

https://github.com/antrea-io/antrea/blob/main/cmd/antrea-agent/agent.go#L382

informer.SetTransform(k8s.NewTrimmer(k8s.TrimPod)) // returns error but we don't check it
return informer

Do you think it would be okay to ignore G104? I havent looked at the remaining 43 issues but they should be much more manageable than g104

[antoninbas]

I did the conversion recently for another smaller repository. When I used the conversion tool that golangci-lint provides, it automatically added the legacy preset which ignores G104: https://github.com/antrea-io/antrea-ui/blob/main/.golangci.yml#L29

I recommend using the conversion tool, focusing on moving to the v2 configuration, and trying to get to parity with what we have today (or as close as possible). If follow up changes are needed / desired (e.g., to enable more linters or rules, or to be more explicit about which rules are disabled), these changes should be performed in a separate PR IMO.

[petertran-avgo]

Are you referring to the migrate sub-command?

[petertran-avgo]

And thanks for the tip about legacy! Down to 36 gosec errors

[antoninbas]

Are you referring to the migrate sub-command?

Yes. I'd suggest running that first. legacy should be added by default, or at least it was in my case.

[petertran-avgo]

Thank you! Reflecting on this now, I recall the exclusions list having extra (at the time I thought) "directories" that didn't make sense to me that I removed. legacy must have been on there