fix(Events): Fix the way to check when event properties are undefined

Valentin Hervieu · Valentin Hervieu · commit e999284b6a1b · 2016-07-06T14:41:43.000+02:00
Fix #365
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+# 5.1.1 (2016-07-06)
+## Fix
+- Fix the way to check when event properties are undefined (#365).
+
 # 5.1.0 (2016-07-02)
 ## Features
 - Add a `pushRange` option (#341).
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "angularjs-slider",
-  "version": "5.1.0",
+  "version": "5.1.1",
   "homepage": "https://github.com/angular-slider/angularjs-slider",
   "authors": [
     "Rafal Zajac <rzajac@gmail.com>",
diff --git a/dist/rzslider.css b/dist/rzslider.css
@@ -1,7 +1,7 @@
-/*! angularjs-slider - v5.1.0 - 
+/*! angularjs-slider - v5.1.1 - 
  (c) Rafal Zajac <rzajac@gmail.com>, Valentin Hervieu <valentin@hervieu.me>, Jussi Saarivirta <jusasi@gmail.com>, Angelin Sirbu <angelin.sirbu@gmail.com> - 
  https://github.com/angular-slider/angularjs-slider - 
- 2016-07-02 */
+ 2016-07-06 */
 .rzslider {
   position: relative;
   display: inline-block;
diff --git a/dist/rzslider.js b/dist/rzslider.js
@@ -1,7 +1,7 @@
-/*! angularjs-slider - v5.1.0 - 
+/*! angularjs-slider - v5.1.1 - 
  (c) Rafal Zajac <rzajac@gmail.com>, Valentin Hervieu <valentin@hervieu.me>, Jussi Saarivirta <jusasi@gmail.com>, Angelin Sirbu <angelin.sirbu@gmail.com> - 
  https://github.com/angular-slider/angularjs-slider - 
- 2016-07-02 */
+ 2016-07-06 */
 /*jslint unparam: true */
 /*global angular: false, console: false, define, module */
 (function(root, factory) {
@@ -1401,7 +1401,7 @@
         /* http://stackoverflow.com/a/12336075/282882 */
         //noinspection JSLint
         var clientXY = this.options.vertical ? 'clientY' : 'clientX';
-        if (clientXY in event) {
+        if (event[clientXY] !== undefined) {
           return event[clientXY];
         }
 
diff --git a/dist/rzslider.min.css b/dist/rzslider.min.css
diff --git a/dist/rzslider.min.js b/dist/rzslider.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "angularjs-slider",
-  "version": "5.1.0",
+  "version": "5.1.1",
   "description": "AngularJS slider directive with no external dependencies. Mobile friendly!.",
   "main": "dist/rzslider.js",
   "repository": {
diff --git a/src/rzslider.js b/src/rzslider.js
@@ -1405,7 +1405,7 @@
         /* http://stackoverflow.com/a/12336075/282882 */
         //noinspection JSLint
         var clientXY = this.options.vertical ? 'clientY' : 'clientX';
-        if (clientXY in event) {
+        if (event[clientXY] !== undefined) {
           return event[clientXY];
         }
 

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "angularjs-slider",`
`3`		`- "version": "5.1.0",`
	`3`	`+ "version": "5.1.1",`
`4`	`4`	`"homepage": "https://github.com/angular-slider/angularjs-slider",`
`5`	`5`	`"authors": [`
`6`	`6`	`"Rafal Zajac <rzajac@gmail.com>",`
Original file line number	Diff line number	Diff line change
`@@ -1405,7 +1405,7 @@`
`1405`	`1405`	`/* http://stackoverflow.com/a/12336075/282882 */`
`1406`	`1406`	`//noinspection JSLint`
`1407`	`1407`	`var clientXY = this.options.vertical ? 'clientY' : 'clientX';`
`1408`		`- if (clientXY in event) {`
	`1408`	`+ if (event[clientXY] !== undefined) {`
`1409`	`1409`	`return event[clientXY];`
`1410`	`1410`	`}`
`1411`	`1411`