The better design pattern would be to handle channel operations without launching unnecessary goroutines

dyamin · dyamin · commit 150184599e99 · 2024-06-03T17:38:07.000+03:00
diff --git a/api/ws/client.go b/api/ws/client.go
@@ -377,37 +377,27 @@ func (c *ClientWs) process(data []byte, e *events.Basic) bool {
 		e := events.Error{}
 		_ = json.Unmarshal(data, &e)
 		if c.ErrChan != nil {
-			go func() {
-				c.ErrChan <- &e
-			}()
+			c.ErrChan <- &e
 		}
 		return true
 	case "subscribe":
 		e := events.Subscribe{}
 		_ = json.Unmarshal(data, &e)
 		if c.SubscribeChan != nil {
-			go func() {
-				c.SubscribeChan <- &e
-			}()
+			c.SubscribeChan <- &e
 		}
 		if c.StructuredEventChan != nil {
-			go func() {
-				c.StructuredEventChan <- e
-			}()
+			c.StructuredEventChan <- e
 		}
 		return true
 	case "unsubscribe":
 		e := events.Unsubscribe{}
 		_ = json.Unmarshal(data, &e)
 		if c.UnsubscribeCh != nil {
-			go func() {
-				c.UnsubscribeCh <- &e
-			}()
+			c.UnsubscribeCh <- &e
 		}
 		if c.StructuredEventChan != nil {
-			go func() {
-				c.StructuredEventChan <- e
-			}()
+			c.StructuredEventChan <- e
 		}
 		return true
 	case "login":
@@ -420,14 +410,10 @@ func (c *ClientWs) process(data []byte, e *events.Basic) bool {
 		e := events.Login{}
 		_ = json.Unmarshal(data, &e)
 		if c.LoginChan != nil {
-			go func() {
-				c.LoginChan <- &e
-			}()
+			c.LoginChan <- &e
 		}
 		if c.StructuredEventChan != nil {
-			go func() {
-				c.StructuredEventChan <- e
-			}()
+			c.StructuredEventChan <- e
 		}
 		return true
 	}
@@ -446,17 +432,13 @@ func (c *ClientWs) process(data []byte, e *events.Basic) bool {
 		e := events.Success{}
 		_ = json.Unmarshal(data, &e)
 		if c.SuccessChan != nil {
-			go func() {
-				c.SuccessChan <- &e
-			}()
+			c.SuccessChan <- &e
 		}
 		if c.StructuredEventChan != nil {
-			go func() {
-				c.StructuredEventChan <- e
-			}()
+			c.StructuredEventChan <- e
 		}
 		return true
 	}
-	go func() { c.RawEventChan <- e }()
+	c.RawEventChan <- e
 	return false
 }
diff --git a/api/ws/public.go b/api/ws/public.go
@@ -383,14 +383,10 @@ func (c *Public) Process(data []byte, e *events.Basic) bool {
 				return false
 			}
 			if c.iCh != nil {
-				go func() {
-					c.iCh <- &e
-				}()
+				c.iCh <- &e
 			}
 			if c.StructuredEventChan != nil {
-				go func() {
-					c.StructuredEventChan <- e
-				}()
+				c.StructuredEventChan <- e
 			}
 			return true
 		case "tickers":
@@ -399,14 +395,10 @@ func (c *Public) Process(data []byte, e *events.Basic) bool {
 				return false
 			}
 			if c.tCh != nil {
-				go func() {
-					c.tCh <- &e
-				}()
+				c.tCh <- &e
 			}
 			if c.StructuredEventChan != nil {
-				go func() {
-					c.StructuredEventChan <- e
-				}()
+				c.StructuredEventChan <- e
 			}
 			return true
 		case "open-interest":
@@ -415,14 +407,10 @@ func (c *Public) Process(data []byte, e *events.Basic) bool {
 				return false
 			}
 			if c.oiCh != nil {
-				go func() {
-					c.oiCh <- &e
-				}()
+				c.oiCh <- &e
 			}
 			if c.StructuredEventChan != nil {
-				go func() {
-					c.StructuredEventChan <- e
-				}()
+				c.StructuredEventChan <- e
 			}
 			return true
 		case "trades":
@@ -431,14 +419,10 @@ func (c *Public) Process(data []byte, e *events.Basic) bool {
 				return false
 			}
 			if c.trCh != nil {
-				go func() {
-					c.trCh <- &e
-				}()
+				c.trCh <- &e
 			}
 			if c.StructuredEventChan != nil {
-				go func() {
-					c.StructuredEventChan <- e
-				}()
+				c.StructuredEventChan <- e
 			}
 			return true
 		case "estimated-price":
@@ -447,14 +431,10 @@ func (c *Public) Process(data []byte, e *events.Basic) bool {
 				return false
 			}
 			if c.edepCh != nil {
-				go func() {
-					c.edepCh <- &e
-				}()
+				c.edepCh <- &e
 			}
 			if c.StructuredEventChan != nil {
-				go func() {
-					c.StructuredEventChan <- e
-				}()
+				c.StructuredEventChan <- e
 			}
 			return true
 		case "mark-price":
@@ -463,14 +443,10 @@ func (c *Public) Process(data []byte, e *events.Basic) bool {
 				return false
 			}
 			if c.mpCh != nil {
-				go func() {
-					c.mpCh <- &e
-				}()
+				c.mpCh <- &e
 			}
 			if c.StructuredEventChan != nil {
-				go func() {
-					c.StructuredEventChan <- e
-				}()
+				c.StructuredEventChan <- e
 			}
 			return true
 		case "price-limit":
@@ -479,14 +455,10 @@ func (c *Public) Process(data []byte, e *events.Basic) bool {
 				return false
 			}
 			if c.plCh != nil {
-				go func() {
-					c.plCh <- &e
-				}()
+				c.plCh <- &e
 			}
 			if c.StructuredEventChan != nil {
-				go func() {
-					c.StructuredEventChan <- e
-				}()
+				c.StructuredEventChan <- e
 			}
 			return true
 		case "opt-summary":
@@ -495,14 +467,10 @@ func (c *Public) Process(data []byte, e *events.Basic) bool {
 				return false
 			}
 			if c.osCh != nil {
-				go func() {
-					c.osCh <- &e
-				}()
+				c.osCh <- &e
 			}
 			if c.StructuredEventChan != nil {
-				go func() {
-					c.StructuredEventChan <- e
-				}()
+				c.StructuredEventChan <- e
 			}
 			return true
 		case "funding-rate":
@@ -511,14 +479,10 @@ func (c *Public) Process(data []byte, e *events.Basic) bool {
 				return false
 			}
 			if c.frCh != nil {
-				go func() {
-					c.frCh <- &e
-				}()
+				c.frCh <- &e
 			}
 			if c.StructuredEventChan != nil {
-				go func() {
-					c.StructuredEventChan <- e
-				}()
+				c.StructuredEventChan <- e
 			}
 			return true
 		case "index-tickers":
@@ -527,14 +491,10 @@ func (c *Public) Process(data []byte, e *events.Basic) bool {
 				return false
 			}
 			if c.itCh != nil {
-				go func() {
-					c.itCh <- &e
-				}()
+				c.itCh <- &e
 			}
 			if c.StructuredEventChan != nil {
-				go func() {
-					c.StructuredEventChan <- e
-				}()
+				c.StructuredEventChan <- e
 			}
 			return true
 		default:
@@ -545,14 +505,10 @@ func (c *Public) Process(data []byte, e *events.Basic) bool {
 					return false
 				}
 				if c.mpcCh != nil {
-					go func() {
-						c.mpcCh <- &e
-					}()
+					c.mpcCh <- &e
 				}
 				if c.StructuredEventChan != nil {
-					go func() {
-						c.StructuredEventChan <- e
-					}()
+					c.StructuredEventChan <- e
 				}
 				return true
 			}
@@ -562,14 +518,10 @@ func (c *Public) Process(data []byte, e *events.Basic) bool {
 					return false
 				}
 				if c.icCh != nil {
-					go func() {
-						c.icCh <- &e
-					}()
+					c.icCh <- &e
 				}
 				if c.StructuredEventChan != nil {
-					go func() {
-						c.StructuredEventChan <- e
-					}()
+					c.StructuredEventChan <- e
 				}
 				return true
 			}
@@ -579,14 +531,10 @@ func (c *Public) Process(data []byte, e *events.Basic) bool {
 					return false
 				}
 				if c.cCh != nil {
-					go func() {
-						c.cCh <- &e
-					}()
+					c.cCh <- &e
 				}
 				if c.StructuredEventChan != nil {
-					go func() {
-						c.StructuredEventChan <- e
-					}()
+					c.StructuredEventChan <- e
 				}
 				return true
 			}
@@ -596,14 +544,10 @@ func (c *Public) Process(data []byte, e *events.Basic) bool {
 					return false
 				}
 				if c.obCh != nil {
-					go func() {
-						c.obCh <- &e
-					}()
+					c.obCh <- &e
 				}
 				if c.StructuredEventChan != nil {
-					go func() {
-						c.StructuredEventChan <- e
-					}()
+					c.StructuredEventChan <- e
 				}
 				return true
 			}

Original file line number	Diff line number	Diff line change
`@@ -383,14 +383,10 @@ func (c Public) Process(data []byte, e events.Basic) bool {`
`383`	`383`	`return false`
`384`	`384`	`}`
`385`	`385`	`if c.iCh != nil {`
`386`		`- go func() {`
`387`		`- c.iCh <- &e`
`388`		`- }()`
	`386`	`+ c.iCh <- &e`
`389`	`387`	`}`
`390`	`388`	`if c.StructuredEventChan != nil {`
`391`		`- go func() {`
`392`		`- c.StructuredEventChan <- e`
`393`		`- }()`
	`389`	`+ c.StructuredEventChan <- e`
`394`	`390`	`}`
`395`	`391`	`return true`
`396`	`392`	`case "tickers":`
`@@ -399,14 +395,10 @@ func (c Public) Process(data []byte, e events.Basic) bool {`
`399`	`395`	`return false`
`400`	`396`	`}`
`401`	`397`	`if c.tCh != nil {`
`402`		`- go func() {`
`403`		`- c.tCh <- &e`
`404`		`- }()`
	`398`	`+ c.tCh <- &e`
`405`	`399`	`}`
`406`	`400`	`if c.StructuredEventChan != nil {`
`407`		`- go func() {`
`408`		`- c.StructuredEventChan <- e`
`409`		`- }()`
	`401`	`+ c.StructuredEventChan <- e`
`410`	`402`	`}`
`411`	`403`	`return true`
`412`	`404`	`case "open-interest":`
`@@ -415,14 +407,10 @@ func (c Public) Process(data []byte, e events.Basic) bool {`
`415`	`407`	`return false`
`416`	`408`	`}`
`417`	`409`	`if c.oiCh != nil {`
`418`		`- go func() {`
`419`		`- c.oiCh <- &e`
`420`		`- }()`
	`410`	`+ c.oiCh <- &e`
`421`	`411`	`}`
`422`	`412`	`if c.StructuredEventChan != nil {`
`423`		`- go func() {`
`424`		`- c.StructuredEventChan <- e`
`425`		`- }()`
	`413`	`+ c.StructuredEventChan <- e`
`426`	`414`	`}`
`427`	`415`	`return true`
`428`	`416`	`case "trades":`
`@@ -431,14 +419,10 @@ func (c Public) Process(data []byte, e events.Basic) bool {`
`431`	`419`	`return false`
`432`	`420`	`}`
`433`	`421`	`if c.trCh != nil {`
`434`		`- go func() {`
`435`		`- c.trCh <- &e`
`436`		`- }()`
	`422`	`+ c.trCh <- &e`
`437`	`423`	`}`
`438`	`424`	`if c.StructuredEventChan != nil {`
`439`		`- go func() {`
`440`		`- c.StructuredEventChan <- e`
`441`		`- }()`
	`425`	`+ c.StructuredEventChan <- e`
`442`	`426`	`}`
`443`	`427`	`return true`
`444`	`428`	`case "estimated-price":`
`@@ -447,14 +431,10 @@ func (c Public) Process(data []byte, e events.Basic) bool {`
`447`	`431`	`return false`
`448`	`432`	`}`
`449`	`433`	`if c.edepCh != nil {`
`450`		`- go func() {`
`451`		`- c.edepCh <- &e`
`452`		`- }()`
	`434`	`+ c.edepCh <- &e`
`453`	`435`	`}`
`454`	`436`	`if c.StructuredEventChan != nil {`
`455`		`- go func() {`
`456`		`- c.StructuredEventChan <- e`
`457`		`- }()`
	`437`	`+ c.StructuredEventChan <- e`
`458`	`438`	`}`
`459`	`439`	`return true`
`460`	`440`	`case "mark-price":`
`@@ -463,14 +443,10 @@ func (c Public) Process(data []byte, e events.Basic) bool {`
`463`	`443`	`return false`
`464`	`444`	`}`
`465`	`445`	`if c.mpCh != nil {`
`466`		`- go func() {`
`467`		`- c.mpCh <- &e`
`468`		`- }()`
	`446`	`+ c.mpCh <- &e`
`469`	`447`	`}`
`470`	`448`	`if c.StructuredEventChan != nil {`
`471`		`- go func() {`
`472`		`- c.StructuredEventChan <- e`
`473`		`- }()`
	`449`	`+ c.StructuredEventChan <- e`
`474`	`450`	`}`
`475`	`451`	`return true`
`476`	`452`	`case "price-limit":`
`@@ -479,14 +455,10 @@ func (c Public) Process(data []byte, e events.Basic) bool {`
`479`	`455`	`return false`
`480`	`456`	`}`
`481`	`457`	`if c.plCh != nil {`
`482`		`- go func() {`
`483`		`- c.plCh <- &e`
`484`		`- }()`
	`458`	`+ c.plCh <- &e`
`485`	`459`	`}`
`486`	`460`	`if c.StructuredEventChan != nil {`
`487`		`- go func() {`
`488`		`- c.StructuredEventChan <- e`
`489`		`- }()`
	`461`	`+ c.StructuredEventChan <- e`
`490`	`462`	`}`
`491`	`463`	`return true`
`492`	`464`	`case "opt-summary":`
`@@ -495,14 +467,10 @@ func (c Public) Process(data []byte, e events.Basic) bool {`
`495`	`467`	`return false`
`496`	`468`	`}`
`497`	`469`	`if c.osCh != nil {`
`498`		`- go func() {`
`499`		`- c.osCh <- &e`
`500`		`- }()`
	`470`	`+ c.osCh <- &e`
`501`	`471`	`}`
`502`	`472`	`if c.StructuredEventChan != nil {`
`503`		`- go func() {`
`504`		`- c.StructuredEventChan <- e`
`505`		`- }()`
	`473`	`+ c.StructuredEventChan <- e`
`506`	`474`	`}`
`507`	`475`	`return true`
`508`	`476`	`case "funding-rate":`
`@@ -511,14 +479,10 @@ func (c Public) Process(data []byte, e events.Basic) bool {`
`511`	`479`	`return false`
`512`	`480`	`}`
`513`	`481`	`if c.frCh != nil {`
`514`		`- go func() {`
`515`		`- c.frCh <- &e`
`516`		`- }()`
	`482`	`+ c.frCh <- &e`
`517`	`483`	`}`
`518`	`484`	`if c.StructuredEventChan != nil {`
`519`		`- go func() {`
`520`		`- c.StructuredEventChan <- e`
`521`		`- }()`
	`485`	`+ c.StructuredEventChan <- e`
`522`	`486`	`}`
`523`	`487`	`return true`
`524`	`488`	`case "index-tickers":`
`@@ -527,14 +491,10 @@ func (c Public) Process(data []byte, e events.Basic) bool {`
`527`	`491`	`return false`
`528`	`492`	`}`
`529`	`493`	`if c.itCh != nil {`
`530`		`- go func() {`
`531`		`- c.itCh <- &e`
`532`		`- }()`
	`494`	`+ c.itCh <- &e`
`533`	`495`	`}`
`534`	`496`	`if c.StructuredEventChan != nil {`
`535`		`- go func() {`
`536`		`- c.StructuredEventChan <- e`
`537`		`- }()`
	`497`	`+ c.StructuredEventChan <- e`
`538`	`498`	`}`
`539`	`499`	`return true`
`540`	`500`	`default:`
`@@ -545,14 +505,10 @@ func (c Public) Process(data []byte, e events.Basic) bool {`
`545`	`505`	`return false`
`546`	`506`	`}`
`547`	`507`	`if c.mpcCh != nil {`
`548`		`- go func() {`
`549`		`- c.mpcCh <- &e`
`550`		`- }()`
	`508`	`+ c.mpcCh <- &e`
`551`	`509`	`}`
`552`	`510`	`if c.StructuredEventChan != nil {`
`553`		`- go func() {`
`554`		`- c.StructuredEventChan <- e`
`555`		`- }()`
	`511`	`+ c.StructuredEventChan <- e`
`556`	`512`	`}`
`557`	`513`	`return true`
`558`	`514`	`}`
`@@ -562,14 +518,10 @@ func (c Public) Process(data []byte, e events.Basic) bool {`
`562`	`518`	`return false`
`563`	`519`	`}`
`564`	`520`	`if c.icCh != nil {`
`565`		`- go func() {`
`566`		`- c.icCh <- &e`
`567`		`- }()`
	`521`	`+ c.icCh <- &e`
`568`	`522`	`}`
`569`	`523`	`if c.StructuredEventChan != nil {`
`570`		`- go func() {`
`571`		`- c.StructuredEventChan <- e`
`572`		`- }()`
	`524`	`+ c.StructuredEventChan <- e`
`573`	`525`	`}`
`574`	`526`	`return true`
`575`	`527`	`}`
`@@ -579,14 +531,10 @@ func (c Public) Process(data []byte, e events.Basic) bool {`
`579`	`531`	`return false`
`580`	`532`	`}`
`581`	`533`	`if c.cCh != nil {`
`582`		`- go func() {`
`583`		`- c.cCh <- &e`
`584`		`- }()`
	`534`	`+ c.cCh <- &e`
`585`	`535`	`}`
`586`	`536`	`if c.StructuredEventChan != nil {`
`587`		`- go func() {`
`588`		`- c.StructuredEventChan <- e`
`589`		`- }()`
	`537`	`+ c.StructuredEventChan <- e`
`590`	`538`	`}`
`591`	`539`	`return true`
`592`	`540`	`}`
`@@ -596,14 +544,10 @@ func (c Public) Process(data []byte, e events.Basic) bool {`
`596`	`544`	`return false`
`597`	`545`	`}`
`598`	`546`	`if c.obCh != nil {`
`599`		`- go func() {`
`600`		`- c.obCh <- &e`
`601`		`- }()`
	`547`	`+ c.obCh <- &e`
`602`	`548`	`}`
`603`	`549`	`if c.StructuredEventChan != nil {`
`604`		`- go func() {`
`605`		`- c.StructuredEventChan <- e`
`606`		`- }()`
	`550`	`+ c.StructuredEventChan <- e`
`607`	`551`	`}`
`608`	`552`	`return true`
`609`	`553`	`}`