- Added console user interface to choose between Russell / CH stocks

- Refactoring of the managers to unify the calls

Author: albc4l

App.config

@@ -15,7 +15,6 @@
     <add key="ModelTopDividendsCount" value="200"/>
     <add key="ModelStockPerSectorLimit" value="5"/>
     <add key="ModelPortfolioStockCount" value="20"/>
-    <add key="ModelPortfolioExcelFile" value="portfolio.xlsx"/>
 
   </appSettings>
 </configuration>

DataAccess/BaseDataAccessManager.cs

@@ -1,3 +1,6 @@
+using System.Threading.Tasks;
+using RussellScreener.Entities;
+
 namespace RussellScreener.DataAccess {
     public abstract class BaseDataAccessManager {
 
@@ -10,5 +13,8 @@ public abstract class BaseDataAccessManager {
         public abstract string GetCacheFileName();
 
         #endregion Methods
+
+        public abstract Task<StockRepository> Process();
+        
     }
 }

DataAccess/IexManager.cs

@@ -10,14 +10,27 @@
 namespace RussellScreener.DataAccess {
     public class IexManager : BaseDataAccessManager {
 
+        #region Methods
+
+        public override string GetCacheFileName() {
+            return "russel-iex-stocks.json";
+        }
+
+        public override async Task<StockRepository> Process() {
+            const string etfFilename = "russell.csv";
+            DownloadISharesComposition(etfFilename);
+            List<string> tickers = ExtractISharesTickers(etfFilename);
+            return await DownloadAllStocksFromIex(tickers);
+        }
+
         /// <summary>
         /// Extract all tickers of the holdings within the ETF
         /// It simply goes through the CSV, starting at a given position where data is located (EtfCsvDataLineNumber).
         /// For each line, the first cell (the ticker) is extract and quotes chars are discarded.
         /// </summary>
         /// <param name="csvFilename">Name of the iShares CSV containing the holdings info</param>
         /// <returns>A list of string of tickers</returns>
-        public List<string> ExtractISharesTickers(string csvFilename) {
+        protected List<string> ExtractISharesTickers(string csvFilename) {
             List<string> tickers = new List<string>();
 
             var rawCsvLines = File.ReadLines(csvFilename).ToList();
@@ -35,7 +48,7 @@ public List<string> ExtractISharesTickers(string csvFilename) {
         /// Download the holdings as a CSV from iShares page (as of Nov. 2017)
         /// </summary>
         /// <param name="csvFilename">URL of the CSV - Stored in the app.config</param>
-        public void DownloadISharesComposition(string csvFilename) {
+        protected void DownloadISharesComposition(string csvFilename) {
             var etfCompositionUrl = ConfigurationManager.AppSettings["EtfCompositionUrl"];
             using (WebClient wc = new WebClient()) {
                 wc.DownloadFile(etfCompositionUrl, csvFilename);
@@ -47,7 +60,7 @@ public void DownloadISharesComposition(string csvFilename) {
         /// </summary>
         /// <param name="tickers">List of tickers to download</param>
         /// <returns>A stock repository with all stocks corresponding to the input tickers (except those that failed during fetching)</returns>
-        public async Task<StockRepository> DownloadAllStocksFromIex(List<string> tickers) {
+        protected async Task<StockRepository> DownloadAllStocksFromIex(List<string> tickers) {
             var stockRepository = new StockRepository();
             var iexStockStatsUrl = ConfigurationManager.AppSettings["IexStockStatsUrl"];
             var iexStockCompanyUrl = ConfigurationManager.AppSettings["IexStockCompanyUrl"];
@@ -74,7 +87,7 @@ public async Task<StockRepository> DownloadAllStocksFromIex(List<string> tickers
         /// <param name="iexStockCompanyUrl">IEX API URL for the stock company info</param>
         /// <param name="stockRepository">Repository object where the stock will be added</param>
         /// <returns>A task performing the download of the stock info</returns>
-        public async Task DownloadStockAsync(string ticker, string iexStockStatsUrl, string iexStockCompanyUrl, StockRepository stockRepository) {
+        protected async Task DownloadStockAsync(string ticker, string iexStockStatsUrl, string iexStockCompanyUrl, StockRepository stockRepository) {
             using (var wc = new WebClient()) {
                 try {
                     Stock s = new Stock(ticker);
@@ -94,9 +107,6 @@ public async Task DownloadStockAsync(string ticker, string iexStockStatsUrl, str
             }
         }
 
-        public override string GetCacheFileName() {
-            return "russel-iex-stocks.json";
-        }
-
+        #endregion Methods
     }
 }

DataAccess/SixSwissManager.cs

@@ -14,12 +14,24 @@ public class SixSwissManager : BaseDataAccessManager {
 
         #region Methods
 
+        /// <summary>
+        /// Return the name of the cache to be used for this manager.
+        /// </summary>
+        /// <returns>Name of the cache to use for this manager</returns>
+        public override string GetCacheFileName() {
+            return "swiss-stocks.json";
+        }
+
+        public override async Task<StockRepository> Process() {
+            return await DownloadSwissStockInfos(@".\countries\switzerland\swiss-listings.csv");
+        }
+
         /// <summary>
         /// Asynchronously download Swiss stock information by extracting necessary values from HTML pages
         /// retrieved from SIX.
         /// </summary>
         /// <param name="swissListingsCsv">CSV with Swiss tickers. Prepared in advance.</param>
-        public async Task<StockRepository> DownloadSwissStockInfos(string swissListingsCsv) {
+        protected async Task<StockRepository> DownloadSwissStockInfos(string swissListingsCsv) {
             var rawCsvLines = File.ReadAllLines(swissListingsCsv).ToList();
 
             // Forced to use Regex to extract the values from the raw HTML page returned by SIX. 
@@ -55,7 +67,15 @@ public async Task<StockRepository> DownloadSwissStockInfos(string swissListingsC
                     try {
                         Console.WriteLine(name, ticker);
                         // we are forced to do HTML scrapping, no known CSV or free API for Swiss stocks
-                        var stockStatsRawHtml = await wc.DownloadStringTaskAsync(new Uri(string.Format(swissStatsUrl, isin)));
+                        string url = string.Format(swissStatsUrl, isin);
+
+                        var stockStatsRawHtml = await wc.DownloadStringTaskAsync(new Uri(url));
+                        if (stockStatsRawHtml.Contains("No data is available at present")) {
+                            stockStatsRawHtml = await wc.DownloadStringTaskAsync(new Uri(string.Format(swissStatsUrl.Replace("{0}CHF4", "{0}CHF1"), isin)));
+                            if (stockStatsRawHtml.Contains("No data is available at present")) {
+                                Console.WriteLine("This ticker has some issues with data. Manual checking? " + ticker);
+                            }
+                        } 
 
                         // extract dividend yield from the page
                         stock.Stats.DividendYield = ParseSwissRegexResult(divYieldSwissStockRegex, stockStatsRawHtml);
@@ -87,15 +107,6 @@ private double ParseSwissRegexResult(Regex regex, string rawHtml) {
             return value;
         }
 
-        /// <summary>
-        /// Return the name of the cache to be used for this manager.
-        /// </summary>
-        /// <returns>Name of the cache to use for this manager</returns>
-        public override string GetCacheFileName() {
-            return "swiss-stocks.json";
-        }
-
         #endregion Methods
-
     }
 }

Program.cs

@@ -1,7 +1,4 @@
 using System;
-using System.Collections.Generic;
-using System.Configuration;
-using System.Diagnostics;
 using System.IO;
 using System.Threading.Tasks;
 using RussellScreener.DataAccess;
@@ -18,32 +15,34 @@ public class Program {
         /// <param name="args">Command-line arguments. Not used</param>
         /// <returns>Task for async running</returns>
         public static async Task Main(string[] args) {
-            StockRepositoryManager manager = new StockRepositoryManager();
-
-            SixSwissManager swissManager = new SixSwissManager();
-            //  StockRepository stockRepository = await swissManager.DownloadSwissStockInfos(@".\countries\switzerland\swiss-listings.csv");
-
-            //  manager.WriteStockRepositoryCache(stockRepository, swissManager.GetCacheFileName());
-            var stockRepository = manager.ReadStockRepositoryFromCache(swissManager.GetCacheFileName());
-
-            var screener = new Screener();
-            Console.WriteLine("Analyzing data...");
-            var finalPortfolio = screener.PickStocks(stockRepository);
-            string xlxsFilename = ConfigurationManager.AppSettings["ModelPortfolioExcelFile"];
-
-            ExcelManager excelManager = new ExcelManager();
-            excelManager.WriteExcelFile(xlxsFilename, finalPortfolio, stockRepository.Stocks);
+            Console.WriteLine("1. Russell 1000");
+            Console.WriteLine("2. Swiss Stocks");
+            Console.WriteLine("-- Other keys to Exit --");
+            var choice = Console.ReadKey().Key;
+
+            BaseDataAccessManager manager = null;
+            string xlsxFilename = null;
+            if (choice == ConsoleKey.D1) {
+                manager = new IexManager();
+                xlsxFilename = "russell_portfolio.xlsx";
+            } else if (choice == ConsoleKey.D2) {
+                manager = new SixSwissManager();
+                xlsxFilename = "six_swiss_portfolio.xlsx";
+            } else {
+                return;
+            }
 
-            // await ApplyRussell1000();
+            await Process(manager, xlsxFilename);
         }
 
-        private static async Task ApplyRussell1000() {
-            IexManager iex = new IexManager();
-            var cacheName = iex.GetCacheFileName();
+        private static async Task Process(BaseDataAccessManager dataAccessManager, string outputXlsFilename) {
+            var cacheName = dataAccessManager.GetCacheFileName();
             FileInfo cacheFileInfo = new FileInfo(cacheName);
 
-            // Main workflow
-            // 1. Load data from iShares (the Russell 100 current composition. See DownloadISharesComposition method)
+            Screener screener = new Screener();
+
+            // Main workflow for Russell 1000. Workflows with other data access managers are similar.
+            // 1. Load data from iShares (the Russell 1000 current composition. See DownloadISharesComposition method)
             // 2. Extract tickers
             // 3. Load data from IEX for each ticker (metrics + company info)
             // 4. Store these info into a "StockRepository" which is then saved on disk and used as a cache
@@ -52,8 +51,6 @@ private static async Task ApplyRussell1000() {
             // 6. Apply the strategy rules, get a list of stocks for the portfolio
             // 7. Generate an Excel file with results
 
-            Screener screener = new Screener();
-
             bool refreshCache;
             if (!cacheFileInfo.Exists) {
                 Console.WriteLine("No cache with stocks information exists.");
@@ -65,14 +62,12 @@ private static async Task ApplyRussell1000() {
             }
 
             StockRepositoryManager manager = new StockRepositoryManager();
-
             StockRepository stockRepository;
 
             if (refreshCache) {
                 Console.WriteLine("Refreshing the cache. Download will start now, please wait...");
-                iex.DownloadISharesComposition(ETF_FILENAME);
-                List<string> tickers = iex.ExtractISharesTickers(ETF_FILENAME);
-                stockRepository = await iex.DownloadAllStocksFromIex(tickers);
+
+                stockRepository = await dataAccessManager.Process();
                 manager.WriteStockRepositoryCache(stockRepository, cacheName);
             } else {
                 Console.WriteLine("Reading cache...");
@@ -81,19 +76,18 @@ private static async Task ApplyRussell1000() {
 
             Console.WriteLine("Analyzing data...");
             var finalPortfolio = screener.PickStocks(stockRepository);
-            string xlxsFilename = ConfigurationManager.AppSettings["ModelPortfolioExcelFile"];
 
             ExcelManager excelManager = new ExcelManager();
-            excelManager.WriteExcelFile(xlxsFilename, finalPortfolio, stockRepository.Stocks);
+            excelManager.WriteExcelFile(outputXlsFilename, finalPortfolio, stockRepository.Stocks);
 
-            Console.WriteLine($"An excel file has been generated with your portfolio selection. Name: {xlxsFilename}");
+            Console.WriteLine($"An excel file has been generated with your portfolio selection. Name: {outputXlsFilename}");
             bool showExcel = AskQuestion("Do you want to open this Excel file now?");
             if (showExcel) {
-                Process.Start(xlxsFilename);
+                System.Diagnostics.Process.Start(outputXlsFilename);
             }
 
             Console.WriteLine();
-            Console.WriteLine("Press a key to close this application.");
+            Console.WriteLine("Press Enter to close this application.");
             Console.ReadLine();
         }
 
@@ -109,12 +103,6 @@ public static bool AskQuestion(string question) {
 
         #endregion Methods
 
-        #region Fields
-
-        const string ETF_FILENAME = "russell.csv";
-
-
-        #endregion Fields
 
     }
 }