Skip to content

Commit 470225f

Browse files
authored
feat(Messages): Change message editing method to update() (#241)
Reopening and updating for @zhenyamorozov. Replaces #222 Tested locally and passing
2 parents e417de1 + 4656bcb commit 470225f

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

src/webexpythonsdk/api/messages.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -357,8 +357,8 @@ def delete(self, messageId):
357357
# API request
358358
self._session.delete(API_ENDPOINT + "/" + messageId)
359359

360-
def edit(self, messageId=None, roomId=None, text=None, markdown=None):
361-
"""Edit a message.
360+
def update(self, messageId=None, roomId=None, text=None, markdown=None):
361+
"""Update (edit) a message.
362362
363363
Args:
364364
messageId(str): The ID of the message to be edit.
@@ -391,3 +391,6 @@ def edit(self, messageId=None, roomId=None, text=None, markdown=None):
391391

392392
# Return a message object created from the response JSON data
393393
return self._object_factory(OBJECT_TYPE, json_data)
394+
395+
# Add edit() as an alias to the update() method for backward compatibility
396+
edit = update

tests/api/test_messages.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -364,16 +364,20 @@ def test_get_message_by_id(api, group_room_text_message):
364364
message = api.messages.get(group_room_text_message.id)
365365
assert is_valid_message(message)
366366

367-
368367
def test_delete_message(api, group_room, send_group_room_message):
369368
text = create_string("Message")
370369
message = api.messages.create(group_room.id, text=text)
371370
assert is_valid_message(message)
372371
api.messages.delete(message.id)
373372

374-
375373
def test_edit_message(api, group_room):
376374
text = create_string("Edit this Message")
377375
message = api.messages.create(group_room.id, text=text)
378376
text = create_string("Message Edited")
379377
assert text == api.messages.edit(message.id, group_room.id, text).text
378+
379+
def test_update_message(api, group_room):
380+
text = create_string("Update this Message")
381+
message = api.messages.create(group_room.id, text=text)
382+
text = create_string("Message Updated")
383+
assert text == api.messages.edit(message.id, group_room.id, text).text

0 commit comments

Comments
 (0)