Skip to content

Commit 5db509c

Browse files
committed
feat: Rename NetworkScoresCalculator interface to INetworkScoresCalculator to prevent confusion with class name
1 parent 0fc9670 commit 5db509c

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

src/NetworkScoresCalculator.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import {
33
NetworkScore,
44
NetworkScores,
5-
NetworkScoresCalculator as INetworkScoresCalculator,
5+
INetworkScoresCalculator,
66
WebRTCStatsParsed,
77
} from './types';
88

src/WebRTCIssueDetector.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {
55
EventType,
66
IssueDetector,
77
IssuePayload,
8-
NetworkScoresCalculator,
8+
INetworkScoresCalculator,
99
StatsReportItem,
1010
WebRTCIssueDetectorConstructorParams,
1111
WebRTCStatsParsed,
@@ -21,7 +21,7 @@ class WebRTCIssueDetector {
2121

2222
private readonly detectors: IssueDetector[] = [];
2323

24-
private readonly networkScoresCalculator: NetworkScoresCalculator;
24+
private readonly networkScoresCalculator: INetworkScoresCalculator;
2525

2626
private readonly statsReporter: PeriodicWebRTCStatsReporter;
2727

src/index.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ import WebRTCIssueDetector from './WebRTCIssueDetector';
33
export * from './WebRTCIssueEmitter';
44
export * from './types';
55
export * from './detectors';
6+
7+
export { default as NetworkScoresCalculator } from './NetworkScoresCalculator';
68
export { CompositeRTCStatsParser, PeriodicWebRTCStatsReporter, RTCStatsParser } from './parser';
79

810
export default WebRTCIssueDetector;

src/types.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export interface IssueDetector {
1414
detect(data: WebRTCStatsParsed): IssueDetectorResult;
1515
}
1616

17-
export interface NetworkScoresCalculator {
17+
export interface INetworkScoresCalculator {
1818
calculate(data: WebRTCStatsParsed): NetworkScores;
1919
}
2020

@@ -47,7 +47,7 @@ export interface StatsParser {
4747

4848
export type WebRTCIssueDetectorConstructorParams = {
4949
issueEmitter: WebRTCIssueEmitter;
50-
networkScoresCalculator: NetworkScoresCalculator,
50+
networkScoresCalculator: INetworkScoresCalculator,
5151
detectors: IssueDetector[],
5252
compositeStatsParser: CompositeStatsParser,
5353
statsReporter: PeriodicWebRTCStatsReporter,

0 commit comments

Comments
 (0)