Skip to content

Commit b5904c0

Browse files
committed
Merge branch 'master' of https://github.com/bvanassche/fio
* 'master' of https://github.com/bvanassche/fio: zbd: Make an error message more detailed zbd: Report the zone capacity io_u: Add a debug message in fill_io_u()
2 parents 6946ad5 + adfa7b7 commit b5904c0

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

io_u.c

+3-1
Original file line numberDiff line numberDiff line change
@@ -984,8 +984,10 @@ static int fill_io_u(struct thread_data *td, struct io_u *io_u)
984984
offset = io_u->offset;
985985
if (td->o.zone_mode == ZONE_MODE_ZBD) {
986986
ret = zbd_adjust_block(td, io_u);
987-
if (ret == io_u_eof)
987+
if (ret == io_u_eof) {
988+
dprint(FD_IO, "zbd_adjust_block() returned io_u_eof\n");
988989
return 1;
990+
}
989991
}
990992

991993
if (io_u->offset + io_u->buflen > io_u->file->real_file_size) {

zbd.c

+5-4
Original file line numberDiff line numberDiff line change
@@ -807,8 +807,8 @@ static int parse_zone_info(struct thread_data *td, struct fio_file *f)
807807
goto out;
808808
}
809809

810-
dprint(FD_ZBD, "Device %s has %d zones of size %"PRIu64" KB\n",
811-
f->file_name, nr_zones, zone_size / 1024);
810+
dprint(FD_ZBD, "Device %s has %d zones of size %"PRIu64" KB and capacity %"PRIu64" KB\n",
811+
f->file_name, nr_zones, zone_size / 1024, zones[0].capacity / 1024);
812812

813813
zbd_info = scalloc(1, sizeof(*zbd_info) +
814814
(nr_zones + 1) * sizeof(zbd_info->zone_info[0]));
@@ -848,8 +848,9 @@ static int parse_zone_info(struct thread_data *td, struct fio_file *f)
848848
p->cond = z->cond;
849849

850850
if (j > 0 && p->start != p[-1].start + zone_size) {
851-
log_info("%s: invalid zone data\n",
852-
f->file_name);
851+
log_info("%s: invalid zone data [%d:%d]: %"PRIu64" + %"PRIu64" != %"PRIu64"\n",
852+
f->file_name, j, i,
853+
p[-1].start, zone_size, p->start);
853854
ret = -EINVAL;
854855
goto out;
855856
}

0 commit comments

Comments
 (0)