Skip to content

CodePal is not considering pragma ##CATCH_ALL for check Y_CHECK_CX_ROOT_USAGE #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sachin-b-k opened this issue Aug 11, 2022 · 1 comment
Labels
bug Something isn't working correctly

Comments

@sachin-b-k
Copy link

💡 Code pal for ABAP follows the Clean ABAP. If the issue relates to coding style, please submit it here.

Check Name

CX_ROOT Usage Check

Actual Behavior

QATL reports the error "CX_ROOT should not be used!". In the description it instructs to use the pseudo comment “#EC NEED_CX_ROOT if necessary. But there is also a pragma ##CATCH_ALL. Why does QATL not consider the pragma?

Expected Behavior

CodePal should also consider the pragma ##CATCH_ALL.

@sachin-b-k sachin-b-k added the bug Something isn't working correctly label Aug 11, 2022
@bjoern-jueliger-sap
Copy link
Member

Code Inspector checks cannot support pragmas, see prior discussion in #337.

In general, it is not recommended to run both the Extended Program Check and the equivalent Code Pal check - it's just redundant and leads to this pragma/pseudo comment confusion. Once the new documentation lands (#571), all checks that have SLIN (or other CI) equivalents will note this explicitly in their documentation.

@bjoern-jueliger-sap bjoern-jueliger-sap closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

2 participants