Skip to content

Commit c227f69

Browse files
committed
Using Go modules for dependency management.
1 parent eea7e3d commit c227f69

File tree

1,135 files changed

+293
-635230
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,135 files changed

+293
-635230
lines changed

.travis.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ services:
1010

1111
install:
1212
- go get -u github.com/golang/lint/golint
13-
- go get -u github.com/FiloSottile/vendorcheck
1413
# Install gometalinter and certain linters
1514
- go get -u github.com/alecthomas/gometalinter
1615
- go get -u github.com/client9/misspell/cmd/misspell

Dockerfile.test

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,8 @@ WORKDIR /go/src/github.com/RichardKnop/go-oauth2-server
1414
# Copy the local package files to the container's workspace.
1515
ADD . /go/src/github.com/RichardKnop/go-oauth2-server
1616

17+
# Set GO111MODULE=on variable to activate module support
18+
ENV GO111MODULE on
19+
1720
# Run integration tests as default command
1821
CMD make test-with-coverage

Gopkg.lock

Lines changed: 0 additions & 225 deletions
This file was deleted.

Gopkg.toml

Lines changed: 0 additions & 87 deletions
This file was deleted.

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ fmt:
88
done;
99

1010
lint:
11-
gometalinter --exclude=vendor/ --tests --config=gometalinter.json --disable-all --deadline=120s -E vet -E gofmt -E misspell -E ineffassign -E goimports -E deadcode ./...
11+
gometalinter --tests --disable-all --deadline=120s -E vet -E gofmt -E misspell -E ineffassign -E goimports -E deadcode ./...
1212

1313
golint:
1414
for pkg in ${PACKAGES}; do \

README.md

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -426,13 +426,9 @@ However, because the session service can be replaced via a plugin, any of the av
426426

427427
## Dependencies
428428

429-
According to [Go 1.5 Vendor experiment](https://docs.google.com/document/d/1Bz5-UB7g2uPBdOx-rw5t9MxJwkfpx90cqG9AFL0JAYo), all dependencies are stored in the vendor directory. This approach is called `vendoring` and is the best practice for Go projects to lock versions of dependencies in order to achieve reproducible builds.
429+
Since Go 1.11, a new recommended dependency management system is via [modules](https://github.com/golang/go/wiki/Modules).
430430

431-
This project uses [dep](https://github.com/golang/dep) for dependency management. To update dependencies during development:
432-
433-
```sh
434-
dep ensure
435-
```
431+
This is one of slight weaknesses of Go as dependency management is not a solved problem. Previously Go was officially recommending to use the [dep tool](https://github.com/golang/dep) but that has been abandoned now in favor of modules.
436432

437433
## Setup
438434

database/database.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import (
66

77
"github.com/RichardKnop/go-oauth2-server/config"
88
"github.com/jinzhu/gorm"
9+
910
// Drivers
1011
_ "github.com/lib/pq"
1112
)

0 commit comments

Comments
 (0)