ci: Add pytest coverage checks (#244)

* Add pytest coverage checks

- Add pytest-coverage to dev_requirements
- Move tests to lms root directory
- Add integration with codecov

Author: yammesicka

.flake8

@@ -1,9 +1,9 @@
 [flake8]
 per-file-ignores =
   lms/lmstests/sandbox/linters/defines.py:E501
-  lms/tests/test_exercise_unit_tests.py:Q001
-  lms/tests/test_html_linter.py:Q001,E501
-  lms/tests/test_css_linter.py:Q001,E501
-  lms/tests/test_extractor.py:W293
-  lms/tests/samples/code2.py:E999,W293,W391,E227,E225,E228
+  tests/test_exercise_unit_tests.py:Q001
+  tests/test_html_linter.py:Q001,E501
+  tests/test_css_linter.py:Q001,E501
+  tests/test_extractor.py:W293
+  tests/samples/code2.py:E999,W293,W391,E227,E225,E228
 ignore=I100,S101,I201,W503

.gitattributes

@@ -269,7 +269,7 @@ Procfile          text
 # Ignore files (like .npmignore or .gitignore)
 *.*ignore         text
 
-lms/tests/samples/* text=false 
+tests/samples/* text=false 
 
 #
 # Exclude files from exporting

.github/workflows/cr-checks.yml

@@ -32,4 +32,8 @@ jobs:
       run: |
         export PYTHONPATH=`pwd`
         export PATH=/opt/vnu/vnu-runtime-image/bin:$PATH
-        pytest -vvv --junitxml=junit/test-results.xml
+        pytest -vvv --junitxml=junit/test-results.xml --cov-report=xml --cov=lms ./tests
+    - name: Upload coverage to Codecov
+      uses: codecov/codecov-action@v1.0.13
+      with:
+        file: coverage.xml

dev_requirements.txt

@@ -1,3 +1,4 @@
 debugpy==1.0.0rc2
 ipdb==0.13.3
+pytest-cov==2.10.1
 pytest-env==0.6.2

lms/tests/__init__.py renamed to tests/__init__.py

@@ -1,3 +1,3 @@
-# Upload 3141
-
-"""Normal exercise"""
+# Upload 3141
+
+"""Normal exercise"""

lms/tests/conftest.py renamed to tests/conftest.py

@@ -1,12 +1,12 @@
-          
-
-# Upload 3141
-
-Normal exercise
-להלהלה
-
-
-קצת מילים, @!%^%^& וסימנים מוזרים
-רווח בסוף yay
-
-
+          
+
+# Upload 3141
+
+Normal exercise
+להלהלה
+
+
+קצת מילים, @!%^%^& וסימנים מוזרים
+רווח בסוף yay
+
+

lms/tests/samples/Upload_1.zip renamed to tests/samples/Upload_1.zip

@@ -3,7 +3,7 @@
 from lms.lmsdb import models
 from lms.lmstests.public.identical_tests import tasks
 from lms.models import notifications
-from lms.tests import conftest
+from tests import conftest
 
 
 SOME_CODE = "print('Hello Word')"

lms/tests/samples/Upload_123.zip renamed to tests/samples/Upload_123.zip

@@ -3,7 +3,7 @@
 import shutil
 
 from lms.utils import config_migrator
-from lms.tests import conftest
+from tests import conftest
 
 
 CONFIG_EXAMPLE_FILE = pathlib.Path(conftest.SAMPLES_DIR) / 'config.py.example'

lms/tests/samples/__init__.py renamed to tests/samples/__init__.py

@@ -9,8 +9,8 @@
 from lms.extractors.base import File
 from lms.lmsdb.models import Exercise, User
 from lms.lmsweb import routes
-from lms.tests import conftest
 from lms.utils import hashing
+from tests import conftest
 
 
 DOWNLOAD_FILE = os.path.join(conftest.SAMPLES_DIR, 'download_test.zip')

lms/tests/samples/code1.py renamed to tests/samples/code1.py

@@ -7,7 +7,7 @@
 from lms.lmstests.public.unittests import executers
 from lms.lmstests.public.unittests import tasks
 from lms.models import notifications
-from lms.tests import conftest
+from tests import conftest
 
 
 STUDENT_CODE = """

lms/tests/samples/code2.py renamed to tests/samples/code2.py

@@ -9,8 +9,8 @@
 import lms.extractors.base as extractor
 import lms.extractors.ziparchive as zipfilearchive
 from lms.lmsdb.models import User
-from lms.tests import conftest
-from lms.tests.conftest import SAMPLES_DIR
+from tests import conftest
+from tests.conftest import SAMPLES_DIR
 
 
 class TestExtractor:

lms/tests/samples/config.py.example renamed to tests/samples/config.py.example

@@ -1,6 +1,6 @@
-from lms.tests import conftest
 from lms.lmsdb.models import User
 from lms.lmsweb import webapp
+from tests import conftest
 
 
 class TestLimiter:

lms/tests/samples/config_copy.py renamed to tests/samples/config_copy.py

@@ -1,7 +1,7 @@
 from flask import json
 
 from lms.lmsdb.models import Solution, User
-from lms.tests import conftest
+from tests import conftest
 
 
 USER_COMMENT_BEFORE_ESCAPING = '<html><body><p>Welcome "LMS"</p></body></html>'

lms/tests/samples/download_test.zip renamed to tests/samples/download_test.zip

@@ -6,7 +6,7 @@
 
 from lms.lmsdb.models import Exercise, Notification, Solution, User
 from lms.models import notifications, solutions
-from lms.tests import conftest
+from tests import conftest
 
 
 class TestNotification:

lms/tests/samples/not_working_test_code.py renamed to tests/samples/not_working_test_code.py

@@ -6,7 +6,7 @@
 from lms.lmstests.public.general import tasks as general_tasks
 from lms.lmsweb import routes
 from lms.models import notifications, solutions
-from lms.tests import conftest
+from tests import conftest
 
 
 celery_async = (