Skip to content

Commit 965ba47

Browse files
authored
Merge pull request #15352 from omoerbeek/rec-simpedottest
rec: in test_SimpleDot.py make sure we have the root DNSKEY in cache, it might require TCP
2 parents 24f3575 + 173e649 commit 965ba47

File tree

1 file changed

+20
-1
lines changed

1 file changed

+20
-1
lines changed

regression-tests.recursor-dnssec/test_SimpleDoT.py

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,25 @@ class SimpleDoTTest(RecursorTest):
2020

2121
@pytest.mark.external
2222
def testTXT(self):
23+
query = dns.message.make_query('.', 'DNSKEY', want_dnssec=True)
24+
query.flags |= dns.flags.AD
25+
26+
# As this test uses external servers, be more generous wrt timeouts than the default 2.0s
27+
res = self.sendUDPQuery(query, timeout=5.0)
28+
29+
self.assertMessageIsAuthenticated(res)
30+
self.assertRcodeEqual(res, 0);
31+
rec_controlCmd = [os.environ['RECCONTROL'],
32+
'--config-dir=%s' % 'configs/' + self._confdir,
33+
'get tcp-outqueries']
34+
try:
35+
ret = subprocess.check_output(rec_controlCmd, stderr=subprocess.STDOUT)
36+
tcpcount = ret
37+
38+
except subprocess.CalledProcessError as e:
39+
print(e.output)
40+
raise
41+
2342
expected = dns.rrset.from_text('dot-test-target.powerdns.org.', 0, dns.rdataclass.IN, 'TXT', 'https://github.com/PowerDNS/pdns/pull/12825')
2443
query = dns.message.make_query('dot-test-target.powerdns.org', 'TXT', want_dnssec=True)
2544
query.flags |= dns.flags.AD
@@ -48,7 +67,7 @@ def testTXT(self):
4867
'get tcp-outqueries']
4968
try:
5069
ret = subprocess.check_output(rec_controlCmd, stderr=subprocess.STDOUT)
51-
self.assertEqual(ret, b'0\n')
70+
self.assertEqual(ret, tcpcount)
5271

5372
except subprocess.CalledProcessError as e:
5473
print(e.output)

0 commit comments

Comments
 (0)