Fixing a bug observed in a project, but could not reproduce it in a test within a reasonable time. Not sure how to reproduce the problem there.

Florian Krämer · Florian Krämer · commit 8977d45c7e45 · 2025-03-29T19:45:48.000+01:00
diff --git a/src/ControlStructureNestingRule.php b/src/ControlStructureNestingRule.php
@@ -64,7 +64,7 @@ private function nodeIsAControlStructure(Node $node): bool
     private function getNestingLevel(Node $node, int $currentLevel = 1): int
     {
         $parent = $node->getAttribute('parent');
-        if ($this->nodeIsAControlStructure($parent)) {
+        if ($parent !== null && $this->nodeIsAControlStructure($parent)) {
             return $this->getNestingLevel($parent, $currentLevel + 1);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ private function nodeIsAControlStructure(Node $node): bool`
`64`	`64`	`private function getNestingLevel(Node $node, int $currentLevel = 1): int`
`65`	`65`	`{`
`66`	`66`	`$parent = $node->getAttribute('parent');`
`67`		`- if ($this->nodeIsAControlStructure($parent)) {`
	`67`	`+ if ($parent !== null && $this->nodeIsAControlStructure($parent)) {`
`68`	`68`	`return $this->getNestingLevel($parent, $currentLevel + 1);`
`69`	`69`	`}`
`70`	`70`