Skip to content

Break up SharedModule into smaller, specific pieces #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewatwood opened this issue Feb 25, 2021 · 0 comments
Open

Break up SharedModule into smaller, specific pieces #20

andrewatwood opened this issue Feb 25, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@andrewatwood
Copy link
Contributor

The SharedModule is a bit of a catch-all right now and can probably be pared down quite a bit. Care was taken elsewhere to organize modules by features but SharedModule didn't get quite as much love on that front and covers a lot of ground: thumbnails, forms, pipes, components for common Dialogs, etc.

These can all be split into more logically organized modules, and imported more deliberately by any dependent modules. Since lazy-loading is configured for routed modules, this may help cut down bundle size, as well as just generally organizing things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant