Improve ion-vue-router rendering tests

Author: michaeltintiuc

.eslintrc.js

@@ -20,6 +20,7 @@ module.exports = {
     'no-console': 0,
     'prettier/prettier': 'error',
     'linebreak-style': ['error', 'unix'],
+    'promise/no-callback-in-promise': 0,
     indent: ['error', 2],
     semi: ['error', 'never'],
     quotes: ['error', 'single'],

src/components/ion-vue-router.vue

@@ -91,7 +91,7 @@ export default {
     leave(el, done) {
       const promise = this.transition(this.enteringEl, el)
       if (!promise) return done()
-      promise.finally(() => done()).catch(err => console.error(err))
+      promise.then(() => done(true)).catch(err => console.error(err))
     },
     enter(el, done) {
       done()

test/ion-vue-router.spec.js

@@ -56,6 +56,38 @@ describe('IonVueRouter', () => {
     expect(component.animated).toBeTruthy()
     expect(component.name).toBe('default')
   })
+
+  it('Catches back button click event', () => {
+    const constructor = Vue.extend(IonVueRouter)
+    const component = new constructor()
+    component.catchIonicGoBack({})
+  })
+
+  it('Transitions correctly', () => {
+    expect.assertions(4)
+
+    const constructor = Vue.extend(IonVueRouter)
+    const component = new constructor({ router: new Router() })
+
+    component.$refs.ionRouterOutlet = mockIonRouterOutlet()
+    expect(component.transition()).toBeFalsy()
+
+    component.enteringEl = document.createElement('div')
+    component.leave(document.createElement('h1'), res => {
+      expect(res).toBeTruthy()
+    })
+
+    component.leave(null, res => {
+      expect(res).toBeInstanceOf(Error)
+    })
+
+    component
+      .transition(document.createElement('div'), document.createElement('h1'))
+      .then(res => {
+        return expect(res).toBeTruthy()
+      })
+      .catch(err => console.error(err))
+  })
 })
 
 function Toolbar() {
@@ -105,3 +137,17 @@ function Page() {
       </ion-page>`,
   })
 }
+
+function mockIonRouterOutlet() {
+  return {
+    componentOnReady() {
+      return new Promise(resolve => {
+        return resolve({
+          commit() {
+            return true
+          },
+        })
+      })
+    },
+  }
+}