Skip to content

Include filter throws errors #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OscarAtFatshark opened this issue Aug 8, 2024 · 3 comments
Open

Include filter throws errors #8

OscarAtFatshark opened this issue Aug 8, 2024 · 3 comments
Assignees

Comments

@OscarAtFatshark
Copy link

Hi!

I am trying to get the include option to work for our Github projects, but it's not behaving according to specifications from what I can tell, and is not consistent with how it works locally when I run on my Windows 10 machine using the 2024.1.3 version (same as I use for the Github action).

I'm trying to join several files for the include argument using the ';' delimiter, but I get a complaint from the plugin when it parses it, see image below.
image

I've also tested with forward slashes, and this gives a different error
image

If I just run the same thing in Windows 10 on my machine in Powershell jb inspectcode -o="testie.txt" -f=Text --no-build --include="**\Test2.cs;**\test1.cs" ".\WpfApp1\WpfApp1.sln" I get no issues whatsoever
image

Attached is the output of a full run of the step with backward slashes in Github.

jb_inspectcode_action_failure.txt

If I am doing it the wrong way somehow, how is this supposed to be done?

Best regards,
Oscar

@derigel23
Copy link
Collaborator

Wrap them in quotes?

@derigel23 derigel23 self-assigned this Aug 17, 2024
@OscarAtFatshark
Copy link
Author

OscarAtFatshark commented Sep 9, 2024

Sorry for slow reply, been off for a while.

If I try "**\Test2.cs;**\test1.cs" it fails as well, so it doesn't make any difference what I can tell.

image

This is how the command line call looks. Seems like perhaps the quotation marks aren't propagated to the MODIFIED_FILES variable, not sure if that is significant or not.
image

@OscarAtFatshark
Copy link
Author

@derigel23 is there any progress on this, or do you have any other ideas I can try out? Currently preventing me from using it in our pipeline unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants