Skip to content

CallbackController.cs line 85 - variable "tempState" is never used??? #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AugustZellmer opened this issue Mar 23, 2020 · 2 comments

Comments

@AugustZellmer
Copy link

The code goes through all of this work to create a GUID, store it, and pass it to the auth endpoint, but (unless I'm misunderstanding something) it never actually checks to verify that the auth endpoint returns the correct GUID.

@nimisha84
Copy link
Contributor

You are right. It should be checked on the client side as per docs to make sure that state returned is the same after callback. if you are using this sample and can add a check and do a pull, it would be great.

@AugustZellmer
Copy link
Author

AugustZellmer commented Jun 3, 2020

I know this isn't a complex change, but it's still not a change I've had time to make.
Edit: I will not have time to make this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants