Refactor homepage to RecyclerView

Author: Gear61

app/src/main/java/randomappsinc/com/sqlpractice/activities/MainActivity.java

@@ -4,9 +4,9 @@
 import android.net.Uri;
 import android.os.Bundle;
 import android.support.annotation.NonNull;
+import android.support.v7.widget.RecyclerView;
 import android.view.Menu;
 import android.view.MenuItem;
-import android.widget.ListView;
 
 import com.afollestad.materialdialogs.DialogAction;
 import com.afollestad.materialdialogs.MaterialDialog;
@@ -15,7 +15,6 @@
 import butterknife.BindString;
 import butterknife.BindView;
 import butterknife.ButterKnife;
-import butterknife.OnItemClick;
 import randomappsinc.com.sqlpractice.R;
 import randomappsinc.com.sqlpractice.adapters.QuestionsAdapter;
 import randomappsinc.com.sqlpractice.database.DataSource;
@@ -25,9 +24,10 @@
 import randomappsinc.com.sqlpractice.utils.ToastUtils;
 import randomappsinc.com.sqlpractice.utils.Utils;
 
-public class MainActivity extends StandardActivity implements LibraryDialog.Listener {
+public class MainActivity extends StandardActivity
+        implements LibraryDialog.Listener, QuestionsAdapter.Listener {
 
-    @BindView(R.id.question_list) ListView questionList;
+    @BindView(R.id.question_list) RecyclerView questionList;
     @BindString(R.string.question_number) String questionTemplate;
 
     private QuestionsAdapter questionsAdapter;
@@ -51,7 +51,7 @@ protected void onCreate(Bundle savedInstanceState) {
         DataSource dataSource = new DataSource(this);
         dataSource.refreshTables();
 
-        questionsAdapter = new QuestionsAdapter(this, questionTemplate);
+        questionsAdapter = new QuestionsAdapter(this, questionTemplate, this);
         questionList.setAdapter(questionsAdapter);
 
         if (preferencesManager.shouldAskToRate()) {
@@ -81,8 +81,8 @@ public void onClick(@NonNull MaterialDialog dialog, @NonNull DialogAction which)
                 .show();
     }
 
-    @OnItemClick(R.id.question_list)
-    public void onItemClick(int position) {
+    @Override
+    public void onQuestionClicked(int position) {
         Intent intent = new Intent(this, QuestionActivity.class);
         intent.putExtra(Constants.QUESTION_NUMBER_KEY, position);
         startActivity(intent);

app/src/main/java/randomappsinc/com/sqlpractice/adapters/QuestionsAdapter.java

@@ -1,27 +1,35 @@
 package randomappsinc.com.sqlpractice.adapters;
 
 import android.content.Context;
+import android.support.annotation.NonNull;
+import android.support.v7.widget.RecyclerView;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
-import android.widget.BaseAdapter;
 import android.widget.TextView;
 
 import butterknife.BindColor;
 import butterknife.BindView;
 import butterknife.ButterKnife;
+import butterknife.OnClick;
 import randomappsinc.com.sqlpractice.R;
 import randomappsinc.com.sqlpractice.database.QuestionServer;
 import randomappsinc.com.sqlpractice.utils.PreferencesManager;
 
-public class QuestionsAdapter extends BaseAdapter {
+public class QuestionsAdapter extends RecyclerView.Adapter<QuestionsAdapter.QuestionViewHolder> {
+
+    public interface Listener {
+        void onQuestionClicked(int position);
+    }
 
     private String[] questionList = new String[QuestionServer.getNumQuestions()];
     private PreferencesManager preferencesManager;
+    private Listener listener;
 
-    public QuestionsAdapter(Context context, String questionTemplate) {
+    public QuestionsAdapter(Context context, String questionTemplate, Listener listener) {
         preferencesManager = new PreferencesManager(context);
         populateList(questionTemplate);
+        this.listener = listener;
     }
 
     // Fills in "Question 1, Question 2, etc..." list
@@ -31,19 +39,31 @@ private void populateList(String questionTemplate) {
         }
     }
 
-    public int getCount() {
-        return questionList.length;
+    public long getItemId(int position) {
+        return position;
     }
 
-    public String getItem(int position) {
-        return questionList[position];
+    @NonNull
+    @Override
+    public QuestionViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
+        View itemView = LayoutInflater.from(parent.getContext()).inflate(
+                R.layout.question_list_item,
+                parent,
+                false);
+        return new QuestionViewHolder(itemView);
     }
 
-    public long getItemId(int position) {
-        return position;
+    @Override
+    public void onBindViewHolder(@NonNull QuestionViewHolder holder, int position) {
+        holder.loadQuestion(position);
     }
 
-    class QuestionViewHolder {
+    @Override
+    public int getItemCount() {
+        return questionList.length;
+    }
+
+    class QuestionViewHolder extends RecyclerView.ViewHolder {
         @BindView(R.id.question_number) TextView questionNumber;
         @BindView(R.id.tagged_lessons) TextView taggedLessons;
         @BindView(R.id.completion_icon) TextView completionIcon;
@@ -52,6 +72,7 @@ class QuestionViewHolder {
         @BindColor(R.color.red) int red;
 
         QuestionViewHolder(View view) {
+            super(view);
             ButterKnife.bind(this, view);
         }
 
@@ -63,27 +84,13 @@ void loadQuestion(int position) {
                 completionIcon.setText(R.string.x_icon);
                 completionIcon.setTextColor(red);
             }
-
-            questionNumber.setText(getItem(position));
+            questionNumber.setText(questionList[position]);
             taggedLessons.setText(QuestionServer.getQuestionServer().getQuestion(position).getIdeasList());
         }
-    }
 
-    public View getView(int position, View view, ViewGroup parent) {
-        QuestionViewHolder holder;
-        if (view == null) {
-            LayoutInflater inflater = (LayoutInflater) parent.getContext()
-                    .getSystemService(Context.LAYOUT_INFLATER_SERVICE);
-            if (inflater == null) {
-                throw new RuntimeException("Unable to get a layout inflater to render questions");
-            }
-            view = inflater.inflate(R.layout.question_list_item, parent, false);
-            holder = new QuestionViewHolder(view);
-            view.setTag(holder);
-        } else {
-            holder = (QuestionViewHolder) view.getTag();
+        @OnClick(R.id.parent)
+        void onQuestionClicked() {
+            listener.onQuestionClicked(getAdapterPosition());
         }
-        holder.loadQuestion(position);
-        return view;
     }
 }

app/src/main/java/randomappsinc/com/sqlpractice/utils/Utils.java

@@ -87,4 +87,4 @@ public static void loadMenuIcon(Menu menu, int itemId, Icon icon, Context contex
                         .colorRes(R.color.white)
                         .actionBarSize());
     }
-}
+}

app/src/main/res/layout/activity_main.xml

@@ -1,9 +1,10 @@
-<ListView
+<android.support.v7.widget.RecyclerView
     xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
     android:id="@+id/question_list"
-    android:divider="@null"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:paddingTop="4dp"
     android:paddingBottom="4dp"
-    android:clipToPadding="false"/>
+    android:clipToPadding="false"
+    app:layoutManager="android.support.v7.widget.LinearLayoutManager"/>

app/src/main/res/layout/question_list_item.xml

@@ -2,6 +2,7 @@
     xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:card_view="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
+    android:id="@+id/parent"
     android:background="@color/background_light_gray"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"