From ee2b525c8fde497d53b06cc4fb92f20782d68231 Mon Sep 17 00:00:00 2001 From: Valentin Rey Rosell Date: Wed, 12 Mar 2025 11:45:58 +0100 Subject: [PATCH 1/2] Explicitly set browser to nil if browser type is not found --- .gitignore | 4 ++++ packages/react-native-app-auth/ios/RNAppAuth.m | 3 +++ 2 files changed, 7 insertions(+) diff --git a/.gitignore b/.gitignore index e545102e..6edaa449 100644 --- a/.gitignore +++ b/.gitignore @@ -33,6 +33,10 @@ android/gradle/ android/gradlew android/gradlew.bat +# Android/Eclipse +# +android/.settings/ + # node.js # node_modules/ diff --git a/packages/react-native-app-auth/ios/RNAppAuth.m b/packages/react-native-app-auth/ios/RNAppAuth.m index 938c045c..a4afddc6 100644 --- a/packages/react-native-app-auth/ios/RNAppAuth.m +++ b/packages/react-native-app-auth/ios/RNAppAuth.m @@ -717,6 +717,9 @@ - (NSString*)getErrorCode: (NSError*) error defaultCode: (NSString *) defaultCod } }; BrowserBlock browser = browsers[browserType]; + if (!browser) { + return nil; + } return browser(); } #endif From 443871baddd73e8b2527ab99042e2c1e0f026940 Mon Sep 17 00:00:00 2001 From: Valentin Rey Rosell Date: Wed, 12 Mar 2025 14:26:37 +0100 Subject: [PATCH 2/2] Changeset --- .changeset/nervous-donuts-relate.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/nervous-donuts-relate.md diff --git a/.changeset/nervous-donuts-relate.md b/.changeset/nervous-donuts-relate.md new file mode 100644 index 00000000..9345eb71 --- /dev/null +++ b/.changeset/nervous-donuts-relate.md @@ -0,0 +1,5 @@ +--- +'react-native-app-auth': patch +--- + +#1063 Updated getCustomBrowser: in RNAppAuth.m to explicitly check the return value of browser. If the value is not in the dictionary, it will return nil to trigger an ephemeral session.