Skip to content

Commit 74a6c3d

Browse files
committed
A few fixes from safety eval running
1 parent 62b688b commit 74a6c3d

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

evals/safety_evaluation.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -106,15 +106,13 @@ async def run_simulator(target_url: str, max_simulations: int):
106106
else:
107107
logger.info(f"Failing score from:\nQ: {query}\nA: {answer}\n{evaluator} score: {eval_score}")
108108
numeric_severity_score = eval_score[f"{evaluator}_score"]
109-
if isinstance(numeric_severity_score, float):
109+
if isinstance(numeric_severity_score, float) or isinstance(numeric_severity_score, int):
110110
summary_scores[evaluator]["score_total"] += numeric_severity_score
111111

112112
# Compute the overall statistics
113113
for evaluator in evaluators:
114114
if len(outputs) > 0:
115-
summary_scores[evaluator]["mean_score"] = (
116-
summary_scores[evaluator]["score_total"] / summary_scores[evaluator]["low_count"]
117-
)
115+
summary_scores[evaluator]["mean_score"] = summary_scores[evaluator]["score_total"] / len(outputs)
118116
summary_scores[evaluator]["low_rate"] = summary_scores[evaluator]["low_count"] / len(outputs)
119117

120118
# Save summary scores

src/backend/fastapi_app/postgres_models.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def to_str_for_embedding(self):
5252
table_name = Item.__tablename__
5353

5454
index_ada002 = Index(
55-
"hnsw_index_for_cosine_{table_name}_embedding_ada002",
55+
f"hnsw_index_for_cosine_{table_name}_embedding_ada002",
5656
Item.embedding_ada002,
5757
postgresql_using="hnsw",
5858
postgresql_with={"m": 16, "ef_construction": 64},

src/backend/fastapi_app/query_rewriter.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def extract_search_arguments(original_user_query: str, chat_completion: ChatComp
6969
arg = json.loads(function.arguments)
7070
# Even though its required, search_query is not always specified
7171
search_query = arg.get("search_query", original_user_query)
72-
if "price_filter" in arg and arg["price_filter"]:
72+
if "price_filter" in arg and arg["price_filter"] and isinstance(arg["price_filter"], dict):
7373
price_filter = arg["price_filter"]
7474
filters.append(
7575
{
@@ -78,7 +78,7 @@ def extract_search_arguments(original_user_query: str, chat_completion: ChatComp
7878
"value": price_filter["value"],
7979
}
8080
)
81-
if "brand_filter" in arg and arg["brand_filter"]:
81+
if "brand_filter" in arg and arg["brand_filter"] and isinstance(arg["brand_filter"], dict):
8282
brand_filter = arg["brand_filter"]
8383
filters.append(
8484
{

src/backend/fastapi_app/routes/api_routes.py

+1
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ async def chat_handler(
145145
if isinstance(e, APIError) and e.code == "content_filter":
146146
return ERROR_FILTER
147147
else:
148+
logging.exception("Exception while generating response: %s", e)
148149
return {"error": str(e)}
149150

150151

0 commit comments

Comments
 (0)