resolve_path in MkdirRecursive

Author: adamziel

components/Filesystem/LocalFilesystem.php

@@ -109,19 +109,19 @@ public function copy_file( $from_path, $to_path, $options ) {
 	}
 
 	protected function mkdir_single( $path, $options = array() ) {
-		$path = $this->resolve_path( $path );
+		$resolved_path = $this->resolve_path( $path );
 		if ( $this->exists( $path ) ) {
 			throw new FilesystemException(
 				sprintf( 'Path already exists: %s', $path )
 			);
 		}
-		if ( false === mkdir( $path ) ) {
+		if ( false === @mkdir( $resolved_path ) ) {
 			throw new FilesystemException(
-				sprintf( 'Failed to create directory: %s', $path )
+				sprintf( 'Failed to create directory: %s (%s)', $resolved_path, $path )
 			);
 		}
 		if ( isset( $options['chmod'] ) ) {
-			if ( false === chmod( $path, $options['chmod'] ) ) {
+			if ( false === @chmod( $path, $options['chmod'] ) ) {
 				throw new FilesystemException(
 					sprintf( 'Failed to chmod directory: %s', $path )
 				);

components/Filesystem/Mixin/MkdirRecursive.php

@@ -13,6 +13,11 @@
 trait MkdirRecursive {
 
 	public function mkdir( $path, $options = array() ) {
+		// Windows paths compatibility for LocalFilesystem:
+		if(method_exists($this, 'resolve_path')) {
+			$path = $this->resolve_path( $path );
+		}
+
 		$recursive = $options['recursive'] ?? false;
 		if ( ! $recursive ) {
 			$this->mkdir_single( $path, $options );
@@ -33,6 +38,12 @@ public function mkdir( $path, $options = array() ) {
 		 */
 		$root = rtrim( $this->get_root(), '/' ) . '/';
 		$path = rtrim( $path, '/' ) . '/';
+
+		// Windows paths compatibility for LocalFilesystem:
+		if(method_exists($this, 'resolve_path')) {
+			$root = $this->resolve_path( $root );
+			$path = $this->resolve_path( $path );
+		}
 		if ( strncmp( $path, $root, strlen( $root ) ) !== 0 ) {
 			throw new FilesystemException( sprintf( 'Path %s is not within the root %s', $path, $root ) );
 		}