🚧 Prevent exporting with invalid rotations.

- Added a dialog and exception for exporting a blueprint with invalid cube rotations.

Author: SnaveSutit

src/lang/en.yml

@@ -583,6 +583,12 @@ animated_java.misc.failed_to_export.custom_models.message: You have disabled res
 animated_java.misc.failed_to_export.blueprint_settings.message: There are errors in your blueprint settings! Please fix them before exporting.
 animated_java.misc.failed_to_export.blueprint_settings.error_item: 'Found an issue with {0}:'
 animated_java.misc.failed_to_export.button: Ok
+misc.failed_to_export.invalid_rotation.message: |-
+    Some cubes in your model have an invalid rotations.
+    Cubes must have a rotation of -45, -22.5, 0, 22.5, or 45 degrees, and can only be rotated on a single axis at a time.
+    If you want to rotate a cube more precisely, or on multiple axes, you must put it into a bone and rotate the bone instead.
+    All of the invalid cubes are outlined in red in the editor.
+    Please fix these issues before exporting.
 
 # Format Category
 animated_java.format_category.animated_java: Animated Java

src/mods/cubeOutlineMod.ts

@@ -1,39 +1,11 @@
 import { isCurrentFormat } from '../blueprintFormat'
 import { PACKAGE } from '../constants'
+import { isCubeValid } from '../systems/util'
 import { createBlockbenchMod, createPropertySubscribable } from '../util/moddingTools'
 
 const ERROR_OUTLINE_MATERIAL = Canvas.outlineMaterial.clone()
 ERROR_OUTLINE_MATERIAL.color.set('#ff0000')
 
-function isCubeValid(cube: Cube) {
-	// Cube is automatically valid if it has no rotation
-	if (cube.rotation[0] === 0 && cube.rotation[1] === 0 && cube.rotation[2] === 0) {
-		return true
-	}
-	const rotation = cube.rotation[0] + cube.rotation[1] + cube.rotation[2]
-	// prettier-ignore
-	if (
-		// Make sure the cube is rotated in only one axis by adding all the rotations together, and checking if the sum is equal to one of the rotations.
-		(
-			rotation === cube.rotation[0] ||
-			rotation === cube.rotation[1] ||
-			rotation === cube.rotation[2]
-		)
-		&&
-		// Make sure the cube is rotated in one of the allowed 22.5 degree increments
-		(
-			rotation === -45   ||
-			rotation === -22.5 ||
-			rotation === 0     ||
-			rotation === 22.5  ||
-			rotation === 45
-		)
-	) {
-		return true
-	}
-	return false
-}
-
 createBlockbenchMod(
 	`${PACKAGE.name}:cubeOutlineMod`,
 	{

src/systems/datapackCompiler/index.ts

@@ -526,6 +526,10 @@ async function createAnimationStorage(rig: IRenderedRig, animations: IRenderedAn
 			frames.set(i.toString(), thisFrame)
 			for (const [uuid, node] of Object.entries(animation.modified_nodes)) {
 				const transform = frame.node_transforms[uuid]
+				if (!transform) {
+					console.warn('No transform found for node:', node)
+					continue
+				}
 				if (BONE_TYPES.includes(node.type)) {
 					thisFrame.set(
 						node.type + '_' + node.safe_name,

src/systems/exporter.ts

@@ -12,6 +12,7 @@ import datapackCompiler from './datapackCompiler'
 import { exportJSON } from './jsonCompiler'
 import resourcepackCompiler from './resourcepackCompiler'
 import { renderRig, hashRig } from './rigRenderer'
+import { isCubeValid } from './util'
 
 export class IntentionalExportError extends Error {}
 
@@ -152,6 +153,20 @@ async function actuallyExportProject(forceSave = true) {
 
 export async function exportProject(forceSave = true) {
 	if (!Project) return // TODO: Handle this error better
+
+	if (
+		// Check if 1.21.3 is newer than the target version
+		compareVersions('1.21.3', Project.animated_java.target_minecraft_version) &&
+		!Cube.all.allAre(c => isCubeValid(c))
+	) {
+		Blockbench.showMessageBox({
+			title: translate('misc.failed_to_export.title'),
+			message: translate('misc.failed_to_export.invalid_rotation.message'),
+			buttons: [translate('misc.failed_to_export.button')],
+		})
+		return
+	}
+
 	blueprintSettingErrors.set({})
 	const settingsDialog = openBlueprintSettingsDialog()!
 	// Wait for the dialog to open

src/systems/util.ts

@@ -79,3 +79,32 @@ export const unzip = (data: Uint8Array, options: AsyncUnzipOptions) => {
 		})
 	})
 }
+
+export function isCubeValid(cube: Cube) {
+	// Cube is automatically valid if it has no rotation
+	if (cube.rotation[0] === 0 && cube.rotation[1] === 0 && cube.rotation[2] === 0) {
+		return true
+	}
+	const rotation = cube.rotation[0] + cube.rotation[1] + cube.rotation[2]
+	// prettier-ignore
+	if (
+		// Make sure the cube is rotated in only one axis by adding all the rotations together, and checking if the sum is equal to one of the rotations.
+		(
+			rotation === cube.rotation[0] ||
+			rotation === cube.rotation[1] ||
+			rotation === cube.rotation[2]
+		)
+		&&
+		// Make sure the cube is rotated in one of the allowed 22.5 degree increments
+		(
+			rotation === -45   ||
+			rotation === -22.5 ||
+			rotation === 0     ||
+			rotation === 22.5  ||
+			rotation === 45
+		)
+	) {
+		return true
+	}
+	return false
+}