Build fails: error: no member named 'PhishingDetector' in namespace 'safe_browsing::mojom' #978
Comments
|
I don't know what version you are compiling? Can you please specify here? Also, if you are trying to compile version 132, it is not ready yet. |
130.0.6723.174 By the way, I think the build.log is detailed enough. |
|
Thanks for specifying the version numbers here. From the files you provided, I noticed some patches that seem to come from outside the Thorium repository. Maybe you need to search which patches modified the relevant files. |
|
There is only one I can find that relates to safe_browsing: |
|
Thorium is not and does not intend to be ungoogled. |
|
Why close this issue? It's not caused by ungoogled. ungoogled is just an option provided but I didn't enable it in the failed build. You can see in the build.log that the line start with |
|
Have you tried compiling without the Safe Browsing patch? Also, I need to confirm which commit of Thorium you are currently using? |
Say it again, I didn't build with that patch.
I'm using the tarball in the release: ec81a00 |
|
Okay, try updating Thorium's commit to 6a89d88 Also, since I'm not very familiar with ebuilds, and in the normal workflow of Thorium, neither Alex, midzer, nor I seem to have encountered the problem you described above. In the worst-case scenario, I'd probably have you try turning off safe browsing completely, perhaps in //components/safe_browsing/buildflags.gni, with safe_browsing_mode = 0 receiving is_linux. There may be more areas that need to be modified. |
There is already |
|
You need to confirm whether safe_browsing_mode=0 is really effective. You may need to collect gn args/gn gen and other commands to see if they are executed normally (ideally there should be no errors or warnings). |
|
I can see the lines: Should indicate that If the build still fails, maybe I should try |
The error remains. |
|
Since Thorium's normal workflow does not include making ebuild files, you may need to refer to www-client/chromium to rewrite the ebuild file or seek community support. |
The ebuild is with refererence to ungoogled-chromium::pf4public and I have made some sync with www-client/chromium before (see PF4Public/gentoo-overlay#402). It's really a weird failure since ungoogled-chromium and electron both build fine (basically the same as my thorium ebuild) and I cannot find it on the Internet anywhere. |
|
Have you tried manually fixing all the code paths that have errors? |
|
I'm not familiar with Chromium's code, but I took a look at I guess that gn flag |
|
The error is not seen with |
|
This should be the last error I meet: I guess it may relate to the visibility. So I applied tensorflow/tensorflow@c1bdbb3. But the error still occurrs. Any way to fix this? Any update on this? If not, I have to give up Thorium in Gentoo. |
|
Sorry, neither I nor any other team members have encountered these problems, and no one in the team seems to be using Gentoo, so we may not be able to give you more accurate help. If one day I or other team members get a chance to use Gentoo, things might change. |
|
Can you try building with |
|
Under normal circumstances, you shouldn't run into any of the problems you mention, and there's no need to pass those extra args parameters. |
|
I commented Code snippet: So my journey to Thorium has come to an end! Bye! |
|
No problem, it's your freedom. |
|
Maybe I can pin my hopes on version 132 coming out in a few years :D, but before that I need to give my computer a rest. |
|
I'm trying to install a Gentoo system, and once I'm done with it I'll probably try to compile Thorium. Could you please share the latest ebuild file on your machine? Like the one you sent with the issue? |
|
After recognizing that the last build failure is PF4Public/gentoo-overlay#420, I'm rebuilding Thorium with gperf-3.1. Let me see if it succeeds this time first. |
|
Let's celebrate the successful build of Thorium after the battle lasting for months! I have uploaded the ebuild to https://github.com/blackteahamburger/blackteahamburger-overlay. To build Thorium, you need to There are some notifications: USE flags: you need to set proper USE flags. If you don't know how, just follow the default. Reproducing the failures mentioned above:
Good luck! |
|
I'm sorry, due to some glitches and it seems that I didn't find a way to correctly set up dual graphics card switching and compiling the Gentoo system and its packages took me a lot of time, I had to fall back to the Debian system. Also, I'm glad to see the progress you're making, and it would be even better if we could eliminate some of the non-Thorium-related stuff from it and follow the Thorium workflow more closely. You can check the trunk+version+setup+build sh scripts for more information. |
|
Due to restriction of network access in the ebuild, it is impossible to build Thorium the way described in BUILDING.md (or at least, inconvenient and ugly). And I don't want to sacrifice the flexibility and options provided by the current ebuild. |
|
Alex, this user managed to get Thorium compiling and working on Gentoo, could you take a look? |
|
I still don't understand the mechanism that causes these errors. I'm sure I don't change the files involved in these errors. Is it a problem with the Chromium code itself? You can find the process of fetching the Chromium code here (following https://wiki.gentoo.org/wiki/Project:Chromium/How_to_make_a_Chromium_tarball) and have a check. I still find the workarounds ugly. |
It's still not ready yet because I still need to make sure every USE flag work (or remove them if they really don't). And it is definitely not where the ebuild will ultimately be placed. |
|
I haven't figured out the root cause of the errors you mentioned, maybe some flags in the ebuild? Maybe some dependency issues in the system? Or even problems in the toolchain? You may need to check them one by one, but this process may be painful if you don't have a powerful device or are not using a distributed compiler (and similar compiler acceleration). Alex is the project owner and his opinions need to be heard. Also, I am aware that the ebuild files are not optimal yet, but I appreciate your contribution anyway. |
|
I got some fix inspiration from ungoogled patches, testing if they can work. |
|
Even though I knew I would be able to fix it if I kept doing it, I still felt tired. Let me summarize the whole process:
|
|
Now all build failures and other minor bugs of all use flags are eliminated! Let's congratulate (pretty late though :) )! One downside is that it lacks polly support, because Gentoo's polly support starts from clang-20, but this version is not buildable with it. Waiting for the update! And given the success I've had with ungoogling Thorium, would you consider making ungoogled an option? |
|
Very good! But I think you still need to refer to the linux version args to further tweak the ebuild file and try to make it able to compile multiple different version variants. As for Polly, Thorium isn't using it right now, so you can probably put it aside for now. In addition, Thorium does not want to be ungoogled, which goes against Alex's ideas. |
Users can set "-march=native" or something similar in CFLAGS in make.conf to control compilation, which provides more flexibility. |
build.log.gz
I'm near the final goal of #357, but I meet a build failure:
Not seen when building ungoogled-chromium, electron. Not sure what caused the failure.
The ebuild and patches: thorium.tar.gz
The text was updated successfully, but these errors were encountered: