fix bug from sorting

Author: AdamSpannbauer

R/highlight_test_str.R

@@ -124,7 +124,7 @@ highlight_test_str = function(str, pattern, ignore_case = TRUE,
     # modifying string in place using indices
     # work back to front to avoid disrupting indices
     match_df = data.table::data.table(match_df)
-    match_df = match_df[order(match_ind, capture_start, decreasing = TRUE), ]
+    match_df = match_df[order(match_ind, decreasing = TRUE), ]
   } else {
     match_end = matches_raw + attr(matches_raw, "match.length") - 1
 

tests/testthat/test-highlight_test_str.R

@@ -14,6 +14,21 @@ test_that("highlight_test_str basic", {
 })
 
 
+test_that("welcome screen example", {
+  test_result = regexTestR:::highlight_test_str("This is a test string for testing regex.", "t(es)(t)")
+  expected = paste0(
+    "This is a <span style='background-color:#8DD3C7'>t",
+    "<span style='background-color:#FFFFB3'>es</span>",
+    "<span style='background-color:#BEBADA'>t</span></span>",
+    " string for <span style='background-color:#8DD3C7'>t",
+    "<span style='background-color:#FFFFB3'>es</span>",
+    "<span style='background-color:#BEBADA'>t</span></span>ing regex."
+  )
+
+  expect_equal(test_result, expected)
+})
+
+
 test_that("highlight_test_str perl = FALSE", {
   test_result = regexTestR:::highlight_test_str("abc aaa", "a(..)", perl = FALSE)
   expected = paste0(