Skip to content

Making basilisk module intermediate variables to be protected #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gjaju313 opened this issue Jan 13, 2025 · 1 comment
Open

Making basilisk module intermediate variables to be protected #902

gjaju313 opened this issue Jan 13, 2025 · 1 comment

Comments

@gjaju313
Copy link

Creating new custom modules to add features on top of existing basilisk modules (such as additional biases in body frame and filters to imuSensor module) requires access to its intermediate variables (e.g. omega_PN_P_out for imuSensor) which are declared private.

Declaring them protected will enable using existing basilisk modules as base classes to add features and create custom external modules.

@juan-g-bonilla
Copy link
Contributor

Thank you for the issue, @gjaju313 . This request is usually reasonable, and new code should strive to use protected to facilitate subclassing, like you mentioned. If there are specific models where you'd like to see this change made, feel free to submit a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants