Skip to content

Commit 5653b24

Browse files
committed
client(Options.tsx): add a new input field for the hideTitle query param
1 parent 7c4d882 commit 5653b24

File tree

9 files changed

+59
-31
lines changed

9 files changed

+59
-31
lines changed

client/build/asset-manifest.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/build/index.html

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/build/static/js/main.b6f27464.js renamed to client/build/static/js/main.5d07f8f6.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/build/static/js/main.b6f27464.js.map renamed to client/build/static/js/main.5d07f8f6.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

client/src/components/input/TrueFalseInput.tsx

Lines changed: 22 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { FC } from "react";
2+
import HoverText from "../hover/HoverText";
23

34
interface TrueFalseInputProps {
45
label: string;
@@ -21,29 +22,33 @@ const TrueFalseInput: FC<TrueFalseInputProps> = (props) => {
2122
rounded-md py-1 leading-none text-gh-text outline-none flex items-center
2223
justify-evenly"
2324
>
24-
<div
25-
onClick={() => props.setValue(true)}
26-
className={`py-1 px-4 border border-solid border-gh-border rounded-md
25+
<HoverText label="True">
26+
<div
27+
onClick={() => props.setValue(true)}
28+
className={`py-1 px-4 border border-solid border-gh-border rounded-md
2729
cursor-pointer transition-all duration-150 hover:text-green-400 hover:bg-gh-button ${
2830
props.value
2931
? "text-green-400 bg-gh-button"
3032
: "hover:border-gh-button-border-active"
3133
}`}
32-
>
33-
{props.trueLabel}
34-
</div>
34+
>
35+
{props.trueLabel}
36+
</div>
37+
</HoverText>
3538

36-
<div
37-
onClick={() => props.setValue(false)}
38-
className={`py-1 px-4 border border-solid border-gh-border rounded-md
39-
cursor-pointer transition-all duration-150 hover:text-red-400 hover:bg-gh-button ${
40-
!props.value
41-
? "text-red-400 bg-gh-button"
42-
: "hover:border-gh-button-border-active"
43-
}`}
44-
>
45-
{props.falseLabel}
46-
</div>
39+
<HoverText label="False">
40+
<div
41+
onClick={() => props.setValue(false)}
42+
className={`py-1 px-4 border border-solid border-gh-border rounded-md
43+
cursor-pointer transition-all duration-150 hover:text-red-400 hover:bg-gh-button ${
44+
!props.value
45+
? "text-red-400 bg-gh-button"
46+
: "hover:border-gh-button-border-active"
47+
}`}
48+
>
49+
{props.falseLabel}
50+
</div>
51+
</HoverText>
4752
</div>
4853
</div>
4954
);

client/src/pages/Options.tsx

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -156,21 +156,31 @@ const Options: FC<OptionsProps> = (props) => {
156156

157157
<div className="flex items-start gap-4">
158158
<TrueFalseInput
159-
label="Border"
159+
label="Show Border"
160160
value={card.showBorder}
161161
setValue={(v) =>
162162
setCard({ ...card, showBorder: v, lines: card.lines })
163163
}
164-
trueLabel="Show"
165-
falseLabel="Hide"
164+
trueLabel="T"
165+
falseLabel="F"
166166
/>
167167

168168
<TrueFalseInput
169-
label="Background"
169+
label="Hide Background"
170170
value={card.hideBg}
171171
setValue={(v) => setCard({ ...card, hideBg: v, lines: card.lines })}
172-
trueLabel="Show"
173-
falseLabel="Hide"
172+
trueLabel="T"
173+
falseLabel="F"
174+
/>
175+
176+
<TrueFalseInput
177+
label="Hide Title"
178+
value={card.hideTitle}
179+
setValue={(v) =>
180+
setCard({ ...card, hideTitle: v, lines: card.lines })
181+
}
182+
trueLabel="T"
183+
falseLabel="F"
174184
/>
175185
</div>
176186
</div>

client/src/types/card.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ export interface Card {
2727
fontFamily: string;
2828
gap: string;
2929
lineHeight: string;
30+
hideTitle: boolean;
3031
lines: Line[];
3132
}
3233

@@ -43,6 +44,7 @@ export const newCard = (): Card => {
4344
title: "My Tech Stack",
4445
lineHeight: "7",
4546
gap: "10",
47+
hideTitle: false,
4648
hideBg: false,
4749
};
4850
};

client/src/utils/generate.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,15 @@ class UrlBuilder {
4545
return this;
4646
}
4747

48+
public hideTitle(hideTitle: boolean): UrlBuilder {
49+
if (hideTitle === this.defaultCard.hideTitle) {
50+
return this;
51+
}
52+
53+
this.url += `hideTitle=${hideTitle}&`;
54+
return this;
55+
}
56+
4857
public align(align: string): UrlBuilder {
4958
if (align === this.defaultCard.align) {
5059
return this;
@@ -136,6 +145,7 @@ export const generateLink = ({
136145
lineHeight,
137146
gap,
138147
hideBg,
148+
hideTitle,
139149
}: Card): string => {
140150
let res = new UrlBuilder()
141151
.title(title)
@@ -150,6 +160,7 @@ export const generateLink = ({
150160
.theme(theme)
151161
.gap(gap)
152162
.hideBg(hideBg)
163+
.hideTitle(hideTitle)
153164
.build();
154165

155166
for (const l of lines) {

0 commit comments

Comments
 (0)